Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): publish modal #658

Merged
merged 12 commits into from
Sep 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export default (
publishing?: publishingType,
publishStatus?: PublishStatus,
defaultAlias?: string,
onPublish?: (publishStatus: PublishStatus) => Promise<void>,
onPublish?: (alias: string | undefined, publishStatus: PublishStatus) => void | Promise<void>,
onClose?: () => void,
onAliasValidate?: (alias: string) => void,
onCopyToClipBoard?: () => void,
Expand Down Expand Up @@ -95,15 +95,17 @@ export default (

const handlePublish = useCallback(async () => {
if (!publishing) return;
const a = publishing !== "unpublishing" ? alias || generateAlias() : undefined;

const mode =
publishing === "unpublishing" ? "unpublished" : !searchIndex ? "limited" : "published";
await onPublish?.(mode);
await onPublish?.(a, mode);
if (publishing === "unpublishing") {
handleClose?.();
} else {
setStatusChange(true);
}
}, [onPublish, publishing, searchIndex, setStatusChange, handleClose]);
}, [alias, generateAlias, onPublish, publishing, searchIndex, setStatusChange, handleClose]);

return {
statusChanged,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ type Props = {
publishing?: publishingType;
validatingAlias?: boolean;
url?: string[];
onPublish: (publishStatus: PublishStatus) => Promise<void>;
onPublish: (alias: string | undefined, publishStatus: PublishStatus) => void | Promise<void>;
onClose?: () => void;
onCopyToClipBoard?: () => void;
onAliasValidate?: (alias: string) => void;
Expand Down Expand Up @@ -79,10 +79,9 @@ const PublishModal: React.FC<Props> = ({
const publishDisabled = useMemo(
() =>
loading ||
(publishing === "unpublishing" && publishStatus === "unpublished") ||
((publishing === "publishing" || publishing === "updating") &&
(!alias || !!validation || validatingAlias || !validAlias)),
[alias, loading, publishStatus, publishing, validation, validAlias, validatingAlias],
[alias, loading, publishing, validation, validAlias, validatingAlias],
);

const modalTitleText = useMemo(() => {
Expand Down Expand Up @@ -125,7 +124,12 @@ const PublishModal: React.FC<Props> = ({
button1={<Button text={secondaryButtonText} buttonType="secondary" onClick={handleClose} />}
button2={
!statusChanged && (
<Button text={primaryButtonText} disabled={publishDisabled} onClick={handlePublish} />
<Button
text={primaryButtonText}
buttonType="primary"
disabled={publishDisabled}
onClick={handlePublish}
/>
)
}
onClose={handleClose}>
Expand Down
12 changes: 9 additions & 3 deletions web/src/beta/features/Editor/tabs/publish/Nav/hooks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,12 @@ import { publishingType } from "./PublishModal";
import { type PublishStatus } from "./PublishModal/hooks";

export default ({ projectId }: { projectId?: string }) => {
const { useProjectQuery, useProjectAliasCheckLazyQuery, usePublishProject } = useProjectFetcher();
const {
useProjectQuery,
useProjectAliasCheckLazyQuery,
usePublishProject,
publishProjectLoading,
} = useProjectFetcher();
const { project } = useProjectQuery(projectId);

const [publishing, setPublishing] = useState<publishingType>("unpublishing");
Expand Down Expand Up @@ -55,10 +60,10 @@ export default ({ projectId }: { projectId?: string }) => {
}, [project?.publishmentStatus]);

const handleProjectPublish = useCallback(
async (publishStatus: PublishStatus) => {
async (alias: string | undefined, publishStatus: PublishStatus) => {
await usePublishProject(publishStatus, projectId, alias);
},
[projectId, alias, usePublishProject],
[projectId, usePublishProject],
);

const handleOpenProjectSettings = useCallback(() => {
Expand All @@ -78,6 +83,7 @@ export default ({ projectId }: { projectId?: string }) => {
return {
publishing,
publishStatus,
publishProjectLoading,
dropdownOpen,
modalOpen,
alias,
Expand Down
12 changes: 5 additions & 7 deletions web/src/beta/features/Editor/tabs/publish/Nav/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ const Nav: React.FC<Props> = ({ projectId, selectedProjectType, onProjectTypeCha
alias,
validAlias,
validatingAlias,
publishProjectLoading,
handleModalOpen,
handleModalClose,
setDropdown,
Expand All @@ -51,6 +52,7 @@ const Nav: React.FC<Props> = ({ projectId, selectedProjectType, onProjectTypeCha
[publishStatus, t],
);

const checkPublished: boolean = publishStatus === "limited" || publishStatus === "published";
return (
<>
<StyledSecondaryNav>
Expand Down Expand Up @@ -90,13 +92,8 @@ const Nav: React.FC<Props> = ({ projectId, selectedProjectType, onProjectTypeCha
onClick: () => handleModalOpen("unpublishing"),
},
{
name: t("Publish"),
onClick: () =>
handleModalOpen(
publishStatus === "limited" || publishStatus === "published"
? "updating"
: "publishing",
),
name: checkPublished ? t("Update") : t("Publish"),
onClick: () => handleModalOpen(checkPublished ? "updating" : "publishing"),
},
{
name: t("Publishing Settings"),
Expand All @@ -109,6 +106,7 @@ const Nav: React.FC<Props> = ({ projectId, selectedProjectType, onProjectTypeCha
</StyledSecondaryNav>
<PublishModal
isVisible={modalOpen}
loading={publishProjectLoading}
publishing={publishing}
publishStatus={publishStatus}
url={config()?.published?.split("{}")}
Expand Down
10 changes: 7 additions & 3 deletions web/src/services/api/projectApi.ts
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,12 @@ export default () => {
[createNewProject, createScene, setNotification, t],
);

const [publishProjectMutation] = useMutation(PUBLISH_PROJECT, {
refetchQueries: ["GetProject"],
});
const [publishProjectMutation, { loading: publishProjectLoading }] = useMutation(
PUBLISH_PROJECT,
{
refetchQueries: ["GetProject"],
},
);

const usePublishProject = useCallback(
async (s: PublishStatus, projectId?: string, alias?: string) => {
Expand Down Expand Up @@ -242,6 +245,7 @@ export default () => {
);

return {
publishProjectLoading,
useProjectQuery,
useProjectAliasCheckLazyQuery,
useCreateProject,
Expand Down
Loading