Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

fix: Button widget #111

Merged
merged 2 commits into from Oct 25, 2021
Merged

fix: Button widget #111

merged 2 commits into from Oct 25, 2021

Conversation

KaWaite
Copy link
Member

@KaWaite KaWaite commented Oct 25, 2021

Overview

Had some issues with the Button widget and Widget (legacy)

What I've done

Fixes/updates/etc:

  • Menu item's icon not showing
  • Button widget's menu not opening on published project reearth repo's issue #145
  • icon & text were too close
  • type "break" had title and icon, but didn't show. Now are more useful (see photos)
  • Changing the background color of the
  • refactor
  • add mask function to theme

Screenshot

Screen Shot 2021-10-22 at 15 44 23

Screen Shot 2021-10-25 at 11 55 15

@netlify
Copy link

netlify bot commented Oct 25, 2021

✔️ Deploy Preview for reearth-web ready!

🔨 Explore the source changes: 340c220

🔍 Inspect the deploy log: https://app.netlify.com/sites/reearth-web/deploys/6176247786306b000715f48b

😎 Browse the preview: https://deploy-preview-111--reearth-web.netlify.app

@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #111 (340c220) into main (cd19746) will decrease coverage by 0.11%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
- Coverage   53.53%   53.41%   -0.12%     
==========================================
  Files          48       48              
  Lines         891      893       +2     
  Branches      119      121       +2     
==========================================
  Hits          477      477              
- Misses        364      366       +2     
  Partials       50       50              
Impacted Files Coverage Δ
src/theme/publishTheme/index.ts 17.64% <0.00%> (-2.36%) ⬇️

@KaWaite KaWaite changed the title Fix widget menus icon fix: Button widget Oct 25, 2021
@KaWaite KaWaite self-assigned this Oct 25, 2021
@KaWaite KaWaite marked this pull request as ready for review October 25, 2021 03:44
@KaWaite KaWaite merged commit b934851 into main Oct 25, 2021
@KaWaite KaWaite deleted the fix-widget-menus-icon branch October 25, 2021 06:29
keiya01 pushed a commit that referenced this pull request Apr 25, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants