Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

fix: zoom to layer functionality #332

Merged
merged 3 commits into from
Oct 24, 2022
Merged

fix: zoom to layer functionality #332

merged 3 commits into from
Oct 24, 2022

Conversation

nina992
Copy link
Contributor

@nina992 nina992 commented Oct 19, 2022

Overview

When pressing zoom to layer and then scrolling out or moving the camera out of the layer , then trying to zoom again , the zoom button doesn't work.

What I've done

adding state to fix that

What I haven't done

How I tested

Screenshot

Which point I want you to review particularly

Memo

@netlify
Copy link

netlify bot commented Oct 19, 2022

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 5081c35
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/635646ded2e7c4000a7ae53e
😎 Deploy Preview https://deploy-preview-332--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nina992 nina992 requested a review from airslice October 19, 2022 12:45
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #332 (e62be3e) into main (27cd7a7) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head e62be3e differs from pull request most recent head 5081c35. Consider uploading reports for the commit 5081c35 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main     #332    +/-   ##
========================================
  Coverage   18.12%   18.13%            
========================================
  Files         512      510     -2     
  Lines       50900    50385   -515     
  Branches      613      613            
========================================
- Hits         9226     9136    -90     
+ Misses      41654    41229   -425     
  Partials       20       20            
Impacted Files Coverage Δ
src/components/molecules/Visualizer/hooks.ts 0.00% <0.00%> (ø)
src/components/molecules/Visualizer/index.tsx 0.00% <0.00%> (ø)
...mponents/organisms/EarthEditor/CanvasArea/hooks.ts 0.00% <0.00%> (ø)
...ponents/organisms/EarthEditor/CanvasArea/index.tsx 0.00% <0.00%> (ø)
src/components/atoms/Plugin/PluginIFrame/index.tsx 37.03% <0.00%> (-3.23%) ⬇️
src/components/atoms/Plugin/index.tsx 31.89% <0.00%> (-1.16%) ⬇️
src/components/atoms/Plugin/IFrame/index.tsx 98.27% <0.00%> (-0.41%) ⬇️
src/components/molecules/Visualizer/Plugin/api.ts 6.08% <0.00%> (-0.12%) ⬇️
src/components/atoms/Plugin/hooks.ts 95.86% <0.00%> (-0.06%) ⬇️
src/components/atoms/Plugin/IFrame/hooks.ts 63.00% <0.00%> (-0.05%) ⬇️
... and 17 more

@KaWaite KaWaite changed the title fix: fix zoom to layer functionality fix: zoom to layer functionality Oct 20, 2022
@nina992 nina992 removed the request for review from airslice October 20, 2022 07:14
@nina992 nina992 merged commit 79b0ddc into main Oct 24, 2022
@nina992 nina992 deleted the fix-zoomToLayer branch October 24, 2022 08:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants