This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
feat: extend plugin API supports get location from screen position #350
Merged
airslice
merged 3 commits into
main
from
feat/plugin-api-get-location-from-screen-position
Nov 10, 2022
Merged
feat: extend plugin API supports get location from screen position #350
airslice
merged 3 commits into
main
from
feat/plugin-api-get-location-from-screen-position
Nov 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reearth-web ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #350 +/- ##
==========================================
+ Coverage 18.09% 18.20% +0.11%
==========================================
Files 512 512
Lines 51055 51131 +76
Branches 619 630 +11
==========================================
+ Hits 9237 9307 +70
- Misses 41797 41803 +6
Partials 21 21
|
rot1024
approved these changes
Nov 9, 2022
KaWaite
approved these changes
Nov 10, 2022
rot1024
reviewed
Nov 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rename getLocationFromScreenPosition
getLoctionFromScreen
?
src/components/molecules/Visualizer/Engine/Cesium/useEngineRef.ts
Outdated
Show resolved
Hide resolved
airslice
deleted the
feat/plugin-api-get-location-from-screen-position
branch
November 10, 2022 03:46
This was referenced Nov 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Plugin need to get the location of certain point on screen.
What I've done
Expose
getLocationFromScreen
to plugin API.What I haven't done
How I tested
Tested with devtool console.
Tested with plugin editor using:
Screenshot
Which point I want you to review particularly
Memo