New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): add an option to disable default PBR to 3dtiles and model features in NLS #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reearth-web ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
keiya01
commented
Jun 23, 2023
web/src/beta/lib/core/engines/Cesium/CustomShaders/NonPBRLightingShader.ts
Show resolved
Hide resolved
airslice
approved these changes
Jun 23, 2023
nina992
approved these changes
Jun 23, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #517 +/- ##
==========================================
+ Coverage 26.65% 26.66% +0.01%
==========================================
Files 1336 1337 +1
Lines 144639 144666 +27
Branches 3483 3483
==========================================
+ Hits 38555 38579 +24
- Misses 104962 104965 +3
Partials 1122 1122
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
CustomShader: https://cesium.com/learn/cesiumjs/ref-doc/CustomShader.html
The original implementation: https://github.com/takram-design-engineering/plateau-view/blob/00fc34eda3d0b22eb7a115a948a6901f0926f860/libs/datasets/src/LambertDiffuseShader.ts#L8
What I've done
pbr
property to3dtiles
andmodel
appearance.What I haven't done
How I tested
Which point I want you to review particularly
Memo