Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): typing for window in beta #518

Merged
merged 2 commits into from Jun 23, 2023
Merged

fix(web): typing for window in beta #518

merged 2 commits into from Jun 23, 2023

Conversation

keiya01
Copy link
Member

@keiya01 keiya01 commented Jun 23, 2023

Overview

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@keiya01 keiya01 self-assigned this Jun 23, 2023
@netlify
Copy link

netlify bot commented Jun 23, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit e2422c1
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/649554ebc4726f0008105532
😎 Deploy Preview https://deploy-preview-518--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the web label Jun 23, 2023
@github-actions github-actions bot requested a review from isoppp June 23, 2023 08:15
@keiya01 keiya01 changed the title chore(web):fix typing for window in beta fix(web): typing for window in beta Jun 23, 2023
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #518 (e2422c1) into main (36ddb20) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #518      +/-   ##
==========================================
- Coverage   26.65%   26.65%   -0.01%     
==========================================
  Files        1336     1336              
  Lines      144628   144631       +3     
  Branches     3483     3483              
==========================================
  Hits        38555    38555              
- Misses     104951   104954       +3     
  Partials     1122     1122              
Flag Coverage Δ
web 23.98% <0.00%> (-0.01%) ⬇️
web-beta 23.98% <0.00%> (-0.01%) ⬇️
web-classic 23.98% <0.00%> (-0.01%) ⬇️
web-utils 23.98% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...eb/src/beta/lib/core/Crust/Plugins/plugin_types.ts 0.00% <0.00%> (ø)

Copy link
Contributor

@isoppp isoppp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@keiya01 keiya01 merged commit b815a96 into main Jun 23, 2023
17 checks passed
@keiya01 keiya01 deleted the fix/type-window branch June 23, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants