Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cache Busting to webpack build #598

Closed
Ranthalion opened this issue Oct 13, 2018 · 4 comments
Closed

Add Cache Busting to webpack build #598

Ranthalion opened this issue Oct 13, 2018 · 4 comments
Assignees
Labels

Comments

@Ranthalion
Copy link
Collaborator

Users may experience problems after upgrading reef-pi since browsers cache static content. This issue can be fixed by using a cache busting scheme during the production webpack build. This should solve the problem of asking users to make sure they clear their cache after upgrade.

@zekth
Copy link
Collaborator

zekth commented Oct 13, 2018

@Ranthalion you want to add HASH in the file path?

Also, http server can bust the cache too by using "modified date" to send to the http client

@Ranthalion
Copy link
Collaborator Author

I don't have any implementation in mind. I think HASH is a typical solution, but I have not researched any alternatives.

@zekth
Copy link
Collaborator

zekth commented Oct 14, 2018

I don't have any implementation in mind. I think HASH is a typical solution, but I have not researched any alternatives.

We can use HASH for release number / revision. Depends on how you want to implement it. Also http server can handle it too. But in our case the best is hash or revision. I'm taking care of it.

@zekth zekth self-assigned this Oct 14, 2018
@ranjib
Copy link
Collaborator

ranjib commented Oct 14, 2018

Cache-control header is another option

@zekth zekth mentioned this issue Oct 15, 2018
@zekth zekth closed this as completed Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants