Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes #604

Merged
merged 3 commits into from Oct 15, 2018
Merged

Bug fixes #604

merged 3 commits into from Oct 15, 2018

Conversation

zekth
Copy link
Collaborator

@zekth zekth commented Oct 15, 2018

Fixing:
#598
#602

@codecov-io
Copy link

Codecov Report

Merging #604 into master will decrease coverage by 0.09%.
The diff coverage is 45.45%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #604     +/-   ##
=========================================
- Coverage   84.99%   84.89%   -0.1%     
=========================================
  Files         214      214             
  Lines        6625     6635     +10     
  Branches      461      462      +1     
=========================================
+ Hits         5631     5633      +2     
- Misses        711      718      +7     
- Partials      283      284      +1
Flag Coverage Δ
#go 75.25% <ø> (-0.06%) ⬇️
#javascript 94.97% <45.45%> (-0.17%) ⬇️
Impacted Files Coverage Δ
jsx/main_panel.jsx 100% <ø> (ø) ⬆️
jsx/notifications/alert.jsx 88.23% <45.45%> (-11.77%) ⬇️
controller/lighting/profile.go 74.62% <0%> (-2.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70fa457...616e070. Read the comment docs.

@ranjib ranjib merged commit 3a5bafb into reef-pi:master Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants