Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore)make pca9685 address configurable #665

Merged
merged 2 commits into from Dec 8, 2018
Merged

(chore)make pca9685 address configurable #665

merged 2 commits into from Dec 8, 2018

Conversation

ranjib
Copy link
Collaborator

@ranjib ranjib commented Dec 6, 2018

No description provided.

@theatrus
Copy link
Contributor

theatrus commented Dec 6, 2018

Note to self: backport in #662

@codecov-io
Copy link

codecov-io commented Dec 6, 2018

Codecov Report

Merging #665 into master will increase coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #665      +/-   ##
==========================================
+ Coverage   83.52%   83.56%   +0.04%     
==========================================
  Files         219      220       +1     
  Lines        6749     6772      +23     
  Branches      477      477              
==========================================
+ Hits         5637     5659      +22     
- Misses        824      825       +1     
  Partials      288      288
Flag Coverage Δ
#go 74.93% <0%> (+0.13%) ⬆️
#javascript 92.46% <ø> (ø) ⬆️
Impacted Files Coverage Δ
jsx/configuration/settings_schema.jsx 100% <ø> (ø) ⬆️
jsx/configuration/settings.jsx 97.33% <ø> (ø) ⬆️
controller/settings.go 90.9% <ø> (ø) ⬆️
controller/reef_pi.go 62.6% <0%> (-0.55%) ⬇️
controller/utils/dev_mode.go 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 196d51e...4cedc50. Read the comment docs.

@ranjib ranjib merged commit 618912c into master Dec 8, 2018
@ranjib ranjib deleted the pca9685_address branch December 28, 2018 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants