Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add portuguese language #799

Merged
merged 4 commits into from Jul 11, 2019
Merged

Add portuguese language #799

merged 4 commits into from Jul 11, 2019

Conversation

ViPeR5000
Copy link
Contributor

add portuguese from Portugal language.

zekth
zekth requested changes Jul 10, 2019
View reviewed changes
front-end/assets/translations/pt-pt.csv Outdated
cancel;cancelar
done;Feito
loading;Carregar
documentation;Documenta��o
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like there is some encoding problem in your file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups my mistake

new version

@zekth
Copy link
Collaborator

zekth commented Jul 10, 2019

Thanks for the contribution, but there is some encoding issues.

@codecov-io
Copy link

Codecov Report

Merging #799 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #799   +/-   ##
=======================================
  Coverage   75.78%   75.78%           
=======================================
  Files         249      249           
  Lines        7565     7565           
  Branches      521      521           
=======================================
  Hits         5733     5733           
  Misses       1505     1505           
  Partials      327      327
Flag Coverage Δ
#go 67.14% <ø> (ø) ⬆️
#javascript 84.62% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4590597...cf73503. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Jul 10, 2019 •
edited

Codecov Report

Merging #799 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #799   +/-   ##
=======================================
  Coverage   75.78%   75.78%           
=======================================
  Files         249      249           
  Lines        7565     7565           
  Branches      521      521           
=======================================
  Hits         5733     5733           
  Misses       1505     1505           
  Partials      327      327
Flag Coverage Δ
#go 67.14% <ø> (ø) ⬆️
#javascript 84.62% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4590597...abac118. Read the comment docs.

zekth
zekth requested changes Jul 10, 2019
View reviewed changes
Copy link
Collaborator

@zekth zekth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 mistakes of encoding remaining. You may copy past from other translation files

front-end/assets/translations/pt-pt.csv Outdated
language:de,Deutsch
language:es,Español
language:it,Italiano
language:hi,हिन्दी
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ew?!

zekth
zekth approved these changes Jul 11, 2019
View reviewed changes
Copy link
Collaborator

@zekth zekth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@ranjib
Copy link
Collaborator

ranjib commented Jul 11, 2019

Thank you @ViPeR5000

@ranjib ranjib merged commit 967f3fc into reef-pi:master Jul 11, 2019
@zekth zekth mentioned this pull request Jul 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zekth zekth zekth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ViPeR5000 @zekth @codecov-io @ranjib