Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GitHub PR Templates? #251

Closed
togume opened this issue Apr 30, 2021 · 1 comment · Fixed by #252
Closed

Use GitHub PR Templates? #251

togume opened this issue Apr 30, 2021 · 1 comment · Fixed by #252
Labels
enhancement good first issue hacktoberfest

Comments

@togume
Copy link

togume commented Apr 30, 2021

How can the GitHub PR template be used? This is the latest on what they recommend, and what we use in our repo:
https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/creating-a-pull-request-template-for-your-repository

I tried following a few commits that have been done over the years but could't figure it out 😭 (i.e. thishttps://github.com//pull/223).

Does anyone know how to use the template in docs/pull_request_template.md in the PR?
@codenamev
Copy link
Collaborator

By default, git-reflow will check for a pull request template file in the following order:

  1. .github/PULL_REQUEST_TEMPLATE.md
  2. .github/PULL_REQUEST_TEMPLATE
  3. PULL_REQUEST_TEMPLATE.md
  4. PULL_REQUEST_TEMPLATE

Unfortunately we don't allow customizing the location of this file, but I'd fully support a PR to introduce that 😄

@codenamev codenamev mentioned this issue Oct 8, 2021
Merged
codenamev added a commit that referenced this issue Nov 1, 2021
@codenamev
Introduce configurable PR and merge commit templates (#252)
eaca7a9 
* Update rubocop styles to prefer double quotes and exclude block length from specs
* Lint git_helpers_spec
* Introduce templates.pull-request git-reflow git-configuration to use custom Pull Request templates
* Introduce templates.merge-commit git-reflow git-configuration to use custom Merge Commit templates

Resolves #251 
Merges #252 
Approved by: @nhance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce configurable PR and merge commit templates reenhanced/gitreflow
2 participants
@codenamev @togume