0 Approvals required to merge Pull request by default

[kopach]

As a user I don't expect that this extension will disable merge button by default. At first, I thought this is some bitbucket bug or I lost some permissions. The same situation happened with my colleagues after I recommended this extension.

How about to set 0 as required amount of approvals by default. So, once user check settings and change this value on something else - it will not be surprise why merge button not working 😄 .

[kopach]

Looks like similar issue but different solution: #32

[reyronald]

Yeah I agree, same thing happened to me the first time.

Actually I think now BitBucket already implemented this feature themselves.

I'll test if the functionality is the same/as expected, and if it is, I might just remove it from the extension entirely.

[reyronald]

I haven't had the time to test this yet, but just wanted to reach out to @andremw to see if you're ok with me removing the feature from the extension if it turns out that the Bitbucket first-party feature correctly replaces it, just in case, do you have anything to add ?

[andremw]

100% ok! 🎉