Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: package script produces valid zip #194

Merged
merged 1 commit into from
Apr 3, 2018
Merged

Conversation

reyronald
Copy link
Member

@reyronald reyronald commented Apr 2, 2018

  • I updated the CHANGELOG.md
  • I tested the changes in this pull request myself

Closes #193

For reference:

mozilla/addons#672
mozilla/addons-linter#1938

@reyronald reyronald added the bug label Apr 2, 2018
@reyronald reyronald self-assigned this Apr 2, 2018
Fix the `package` npm script to use the `archiver` npm package instead
of `admin-zip` so that it produces a valid Zip file.

Closes #193

mozilla/addons#672
mozilla/addons-linter#1938
@reyronald reyronald merged commit 707e4e4 into dev Apr 3, 2018
@reyronald reyronald deleted the fix/package-script branch April 23, 2018 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant