Handle broken zip created with adm-zip in a nicer way #1938
Labels
Comments
2 tasks
reyronald
added a commit
to refined-bitbucket/refined-bitbucket
that referenced
this issue
Apr 2, 2018
Fix the `package` npm script to use the `archiver` npm package instead of `admin-zip` so that it produces a valid Zip file. Closes #193 mozilla/addons#672 mozilla/addons-linter#1938
reyronald
added a commit
to refined-bitbucket/refined-bitbucket
that referenced
this issue
Apr 3, 2018
Fix the `package` npm script to use the `archiver` npm package instead of `admin-zip` so that it produces a valid Zip file. Closes #193 mozilla/addons#672 mozilla/addons-linter#1938
|
@diox should this be an upstream bug in yauzl? |
|
I'm not sure, I'm not familiar enough with the linter and yazl to figure out if that's expected behavior (meaning we should be doing something on our end to catch this) or not. Ultimately is too low priority for us to spend a lot of time on it IMHO, but a contributor would be welcome to do it. |
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this bug should stay open, please comment on the issue with further details. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
adm-zipis a popular node package to generate zip files. Somehow, at least one developer using it end up with a weird zip that the linter can't handle. I've attached the zip file in question to this issue.The error being thrown is
The linter process terminates when hitting that, and that causes a
Validation was unable to complete successfully due to an unexpected error.message on the server.We should handle that in a nicer way - I don't suggest managing to proceed with validation as the zipfile is weird (various linux tools I had also have issues with it, though nothing as bad as the linter) - but at least return a true linter error.
The text was updated successfully, but these errors were encountered: