Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isRepliesSettings and include it in hasRichTextEditor #46

Merged
merged 4 commits into from
Oct 20, 2020
Merged

Add isRepliesSettings and include it in hasRichTextEditor #46

merged 4 commits into from
Oct 20, 2020

Conversation

ocarreterom
Copy link
Contributor

  • add isRepliesSettings
  • improve hasRichTextEditor

Test url:
https://github.com/settings/replies
https://github.com/settings/replies/:id/edit

@ocarreterom
replies settings has a text editor
5e86e06 
- add `isRepliesSettings`
- improve `hasRichTextEditor`
@ocarreterom
add tests
375a1df
@yakov116
Copy link
Member

Thanks for the PR.

Can you move it to line number 352 (Somewhere around there there are other setting pages.

@ocarreterom
Copy link
Contributor Author

Thanks for the PR.

Can you move it to line number 352 (Somewhere around there there are other setting pages.

Done!

@fregante fregante changed the title Replies settings has a text editor Add isRepliesSettings and include it in hasRichTextEditor Oct 20, 2020
@fregante fregante merged commit f44a19b into refined-github:master Oct 20, 2020
@ocarreterom ocarreterom deleted the fix-has-rich-text-editor branch October 20, 2020 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ocarreterom @yakov116 @fregante