Improve branch getter function #4193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 3, 2021
fregante
commented
Apr 3, 2021
| t.is(getCurrentCommittish( | ||
| '/typescript-eslint/typescript-eslint/commits/chore/lerna-4/docs/getting-started/README.md', | ||
| 'History for docs/getting-started/README.md - typescript-eslint/typescript-eslint' | ||
| ), 'chore'); // Wrong, but |
There was a problem hiding this comment.
Needs to be fixed separately
| t.is(getCurrentCommittish( | ||
| '/typescript-eslint/typescript-eslint', | ||
| 'typescript-eslint/typescript-eslint: Monorepo for all the tooling which enables ESLint to support TypeScript' | ||
| ), undefined); |
There was a problem hiding this comment.
Could be fixed separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4187
Follows #4190
Fixes #4178
Fixes #4179
Tests
Most of these are features that depend on GitHubURL
comments-time-machine-linksshouldn't throwhttps://github.com/sindresorhus/refined-github/tree/main/media
deep-reblameshould handle the slashed branchhttps://github.com/typescript-eslint/typescript-eslint/blame/chore/lerna-4/docs/getting-started/README.md
default-branch-buttonshould handle the slashed branchhttps://github.com/typescript-eslint/typescript-eslint/tree/chore/lerna-4/docs/getting-started
edit-files-fastershould handle the slashed branchhttps://github.com/typescript-eslint/typescript-eslint/tree/chore/lerna-4/docs/getting-started
edit-readmeis broken:edit-readmestopped working #4195edit-file-links-in-compare-view: the View file button should work and link to the PR head branch instead of the commithttps://github.com/sindresorhus/refined-github/pull/4193/files
follow-file-renamesshould workhttps://github.com/sindresorhus/refined-github/commits/main?after=936eedbb0bb37a30fc44a2cc7e5f3af31f24a3fc+34&branch=main&path%5B%5D=webpack.config.ts
follow-file-renamesis broken on slashed branches:follow-file-renamesshould handle branch names with slashes, but doesn't #4196fork-source-link-same-view: the header link totypescript-eslint/typescript-eslintshould point to the right folder, supporting the slashed branchhttps://github.com/JounQin/typescript-eslint/tree/ci/workflows/.github
forked-to: the link to your fork (to right) should link to the current folder (branch also must match, so it's unaffected by slashes)https://github.com/sindresorhus/refined-github/tree/main/distribution
And more