Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean-conversation-sidebar broken #4258

Closed
premnepak opened this issue Apr 19, 2021 · 5 comments · Fixed by #4445
Closed

clean-conversation-sidebar broken #4258

premnepak opened this issue Apr 19, 2021 · 5 comments · Fixed by #4445

Comments

@premnepak
Copy link

CHROME Version 90.0.4430.72 (Official Build) (64-bit)

Installed the Chrome Extension and it is not working. I am getting the below console error. (It is a private repo).

Refined GitHub → clean-conversation-sidebar → TypeError: Cannot read property 'remove' of undefined
at clean (refined-github.js:6568)
at runFeature (refined-github.js:1942)
at setupPageLoad (refined-github.js:1955)
at refined-github.js:1988
Search issue: https://github.com/sindresorhus/refined-github/issues?q=is%3Aissue+Cannot%20read%20property%20'remove'%20of%20undefined

Open an issue: https://github.com/sindresorhus/refined-github/issues/new?labels=bug&template=bug_report.md&title=%60clean-conversation-sidebar%60%3A%20Cannot%20read%20property%20'remove'%20of%20undefined

logError @ refined-github.js:1923

image

@premnepak premnepak added the bug label Apr 19, 2021
@yakov116
Copy link
Member

Yup, Looks like they are removing all the class names and making the generic

@yakov116 yakov116 changed the title CHROME clean-conversation-sidebar: Cannot read property 'remove' of undefined clean-conversation-sidebar: Cannot read property 'remove' of undefined Apr 19, 2021
@fregante
Copy link
Member

We’ll have to use select().closest() to find them. Each block likely has a form element with a URL that ends in /assignees or something

@fregante

This comment has been minimized.

@yakov116
Copy link
Member

yakov116 commented Apr 27, 2021

I see aria-label="Select milestones" on for example

https://github.com/sindresorhus/got/issues/1306

@fregante
Copy link
Member

Indeed each section has either the form itself, even when not editable, or some identificative class 🎉

@fregante fregante changed the title clean-conversation-sidebar: Cannot read property 'remove' of undefined clean-conversation-sidebar broken Apr 27, 2021
fregante added a commit that referenced this issue May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants