Move loading logic into each feature

[fregante]

• Move loading logic (when, where) near the feature's code instead of being listed in 3 separate functions (init, onDomReady, ajaxedPagesHandler) in a different file (content.js)
• Avoids the messy content.js list of imports/uselessFunctionNames by halving the file length
• Enables us to actually list all the features in Options (not part of this PR) since they are all added in feature.add('feature-name') on load

This is just a proof of concept so only a feature has been implemented.

[sindresorhus]

👍 This is a great idea.

Change made

[fregante]

Alright, big change. 🎉 I solved all the bugs I noticed for now, but I'm sure there's a few I didn't notice (out of the 83 javascript features 😰)

Need some reviewers to try this together for a few days and then merging it asap, give the overarching patch.

Pinging collaborators and recent contributors: @notlmn @jerone @dertieran @leggsimon @tanmayrajani @fxedel @yakov116

[sindresorhus]

Everyone: Please don’t commit any changes to master until this PR is merged.

[fregante]

@dertieran feature order could just be defined as dependencies in the features.add object if someone built an "import all" webpack plugin. A separate PR can be sent by someone interested in doing implementing that.

For now, even the dependency thing sounds complicated (it must check the validity, remember the order, run when all the features are ready, and run at every run() call)

[jerone]

Last call for reviews. 😄

I finally had time to test it, and the features I use are still working. 👍

[sindresorhus]

Works well now 👌

[fregante]

I'll merge in ~14 hours to allow for more testing.

[yakov116]

Works well here too

[leggsimon]

Noticed a small edge case but not sure if it needs a fix. Out of curiousity though I noticed that refined-github only works if you’re signed in. Is that necessary? I assume this is because some features require authenticated API calls but I wonder whether the features that require a signed in user should define that in includes

eg.

features.add({
	id: 'show-user-top-repositories',
	include: [
		features.isUserProfile,
+		features.userIsSignedIn
	],
	load: features.onAjaxedPages,
	init
});

[sindresorhus]

Noticed a small edge case but not sure if it needs a fix. Out of curiousity though I noticed that refined-github only works if you’re signed in. Is that necessary?

We're not interested in supporting logged-out state. Refined GitHub should not run at all if the user is logged out.

[fregante]

🎉

Thanks all for the reviews!