Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move loading logic into each feature #1694

Merged
merged 22 commits into from Jan 15, 2019
Merged

Move loading logic into each feature #1694

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
4a7493e
Move loading logic into each feature
fregante Jan 7, 2019
c5edfa6
Make it work on unconditioned features
fregante Jan 7, 2019
4dd2ca8
Make it work on unconditioned features /2
fregante Jan 7, 2019
4833832
Renamed loading functions
fregante Jan 7, 2019
4e9e27c
Error if `definition` props are invalid
fregante Jan 7, 2019
8b71d18
Renamed loading functions /2
busches Jan 8, 2019
74cd801
Renamed loading functions /3
busches Jan 8, 2019
c695295
Include domLoaded in onAjaxedPagesRaw
fregante Jan 8, 2019
740147a
Fix mark-unread
fregante Jan 8, 2019
2271de3
Add formal "deinit" function
fregante Jan 8, 2019
9278d0d
Drop safeElementReady from features
fregante Jan 8, 2019
a670fce
Simplify/fix order between mark-unread and open-all-notifications
fregante Jan 8, 2019
c2317a7
Ensure that onAjaxedPages (safe) marks the real end
fregante Jan 8, 2019
c3b51ba
Import all at once
fregante Jan 8, 2019
94b223b
Revert "Import all at once"
fregante Jan 8, 2019
2fefc23
Add explicit excluded pages; rename `dependencies` to `include`
fregante Jan 14, 2019
bd06e8b
Fix back-button-duplicate-avoider order
fregante Jan 14, 2019
0ddb8d9
Rename domLoaded to domReady to facilitate contributions
fregante Jan 14, 2019
6e82b4d
Add simple and advanced examples for features.add
fregante Jan 14, 2019
0d8c5cd
Restore mistakenly-removed error loggin
fregante Jan 15, 2019
bcc04bb
Minor changes to improve readability
fregante Jan 15, 2019
d2d3a47
Rename domReady to onDomReady for consistency
fregante Jan 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
29 changes: 22 additions & 7 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Expand Up @@ -26,6 +26,7 @@
"linkify-issues": "^1.3.0",
"linkify-urls": "^2.2.0",
"onetime": "^2.0.1",
"p-is-promise": "^2.0.0",
"select-dom": "^4.1.3",
"shorten-repo-url": "^1.5.0",
"storm-textarea": "2.0.1",
Expand Down