-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add git-checkout-pr
feature
#3596
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Draft until after lint PR is merged |
All working with I don't have a collaborator with a local PR to test on (but I manually tested on a merged and it worked) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the logic is fine now, but I haven’t tested all the cases. Can you test them and include your testing links? (Of course they’ll be related to you as the viewer)
Co-authored-by: Federico <me@fregante.com>
I tested them all. I keep posting links but they keep getting merged 😿 . |
What I do is find old PRs on large, famous repos so there’s no chance that they get merged quickly. |
Like octoicon 😆 ? |
Remote URL: twbs/bootstrap#30329 |
@fregante do you mind to review? It would be great to have this ship tomorrow! |
@fregante now is the perfect time to review this as we both have PR's open (from local branchs) |
I'll extract the
|
LINKED ISSUES:
Closes Can RG recommend me the command to fetch a PR locally? #2767
TEST URLS:
Remote URL: Mark peer dependencies as optional twbs/bootstrap#30329
Upstream URL: karma: stop excluding polyfill.js from istanbul twbs/bootstrap#30740
Own PR:
undefined
Local PR: I and I am collaborator, I removed the exclude for merged PR from it. You can probably find a PR since you are a collaborator in more repositories then me :).
SCREENSHOT: