-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unfinished-comments
feature
#3694
Add unfinished-comments
feature
#3694
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
What do you think about using a shorter text for the indicator (e.g. |
I suggested the extended text because anything else doesn’t give enough information about what’s going on, especially since this isn’t a GitHub feature. Ideally you want to go back to the tab as soon as possible and finish the comment anyway. |
Co-authored-by: Federico <me@fregante.com>
unfinished-comments
feature
This unfortunately also catches comments that are being sent, for example:
When switching the tab, the comment will be detected as "draft" but will be sent not long after. I think that there should be an event we can listen to so that when the comment is submitted, the label is removed. I wonder how this can be solved easily and comprehensively ( |
We could try listening to the |
Thanks for contributing! 🍄
LINKED ISSUES: Closes Notify the user of unfinished comments in a tab #3680
TEST URLS:
git-checkout-pr
feature #3596 (hidden textareas)Notes:
visibilitychange
event instead ofpageshow
/pagehide
as the latter weren't working for me in Firefox. As an added bonus, it also works when hiding/minifying the whole browser window.(+)
or[*]
(akin to what editors show when a file has been modified but not saved).