Fix console error in list-prs-for-file
#3946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
reviewed
Feb 5, 2021
fregante
reviewed
Feb 5, 2021
| @@ -94,7 +94,7 @@ async function showTimemachineBar(): Promise<void | false> { | |||
| const lastCommitDate = await elementReady([ | |||
| '.repository-content .Box.Box--condensed relative-time', | |||
| '[itemprop="dateModified"] relative-time' // "Repository refresh" layout | |||
| ].join(), {waitForChildren: false}); | |||
| ].join()); | |||
There was a problem hiding this comment.
I don’t think this is correct, we only use the attribute, not the children
There was a problem hiding this comment.
Also if you want to drop all pre-refresh code you can do so in a new PR, as long as no other changes are done in the same PR, because they’d be lost.
There was a problem hiding this comment.
I don’t think this is correct, we only use the attribute, not the children
Going to skip this for now as I don't have time to debug.
Also if you want to drop all pre-refresh code you can do so in a new PR, as long as no other changes are done in the same PR, because they’d be lost.
Sure
This reverts commit e909c45.
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like I missed testing when there are no prs