Drop support for the old GitHub layout #3951
Conversation
|
This will break all of these features on GHE 2.21, which is still supported until June. I would rather wait until then to remove this code. |
|
Maybe we can reopen this PR in June |
Let me finish it then I will close |
|
@fregante please don't review. This went through many rebases, I will mark it ready to review next week sometime. |
The change is that until now we are getting the short hash of the commit. With this change we get the entire hash. Release-tab is messed up. I will redo it. |
|
@yakov116 let me know when this is ready and I'll do a quick test on GHE. |
its ready to test |
|
@yakov116 Is there any meta that you're already took care of but is still unchecked here? #4008 (comment) |
No |
|
@fregante do we plan on doing a release before the first? If not this can be merged. |
|
No, we're waiting for the auto-release. It's up to you if you want to merge this now or after the 21.6.1 release, to give them an extra week of support. |
As long as we don't have any conflicts, I don't care leaving it open. |
| '.repository-content .Box.Box--condensed relative-time', | ||
| '[itemprop="dateModified"] relative-time' // "Repository refresh" layout | ||
| ].join(), {waitForChildren: false}); | ||
| const lastCommitDate = await elementReady('[itemprop="dateModified"] relative-time', {waitForChildren: false}); |
There was a problem hiding this comment.
I messed this one up. I deleted the wrong one
There was a problem hiding this comment.
I see. I was seeing the bar because in Safari is still on 21.6.1
There was a problem hiding this comment.
I did attempt to fix it in the last PR...
Whatever..
As per #3946 (comment)
Tested:
clone-branchrepo-agebugs-tabdownload-folder-buttonsplit-issue-pr-search-resultsreleases-tabtoggle-files-buttonshow-open-prs-of-forkstags-on-commits-listtoggle-files-buttonuser-profile-follower-badgeset-default-repositories-type-to-sourcespull-request-hotkeymore-dropdownmark-merge-commits-in-listfollow-file-renamesdefault-branch-buttoncomments-time-machine-linksci-link