Move download-folder-button to the dropdown
#3952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fregante is this good? |
fregante
reviewed
Feb 9, 2021
fregante
reviewed
Feb 9, 2021
Comment on lines
27
to
30
| <a | ||
| className="dropdown-item btn-link" | ||
| href={downloadUrl.href} | ||
| > |
There was a problem hiding this comment.
Suggested change
| <a | |
| className="dropdown-item btn-link" | |
| href={downloadUrl.href} | |
| > | |
| <a className="dropdown-item btn-link" href={downloadUrl.href}> |
Is btn-link required here? It's not a <button> to begin with
fregante
reviewed
Feb 9, 2021
Co-authored-by: Federico <me@fregante.com>
yakov116
commented
Feb 9, 2021
| </a> | ||
| ); | ||
| for (const deleteButton of select.all(`form[action^="/${getRepo()!.nameWithOwner}/tree/delete"]:not(.rgh-download-folder)`)) { | ||
| deleteButton.classList.add('rgh-download-folder'); |
|
After the outstanding comments, feel free to merge this, #3962 and release a new version via the Actions repo tab 🚢 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LINKED ISSUES:
Resolves Move
download-folder-buttonto the dropdown #3949TEST URLS:
https://github.com/sindresorhus/refined-github/tree/main/media
SCREENSHOT:
I added
repeatOnBackButton: true,since I found that when going from dir to dir it was not applying unless I refreshed (nothing to do with the current PR)