Fix more-dropdown on GHE

[cheap-glitch]

Thanks for contributing! 🍄

1. LINKED ISSUES: Fixes more-dropdown: Cannot read property 'parentElement' of undefined #3953

2. TEST URLS: Any repo page. The "Security" and "Insights" tabs should be moved to the dropdown.

My guess is that the bug is caused by the absence of the "Security" tab when doing:

onlyShowInDropdown('security-tab');
onlyShowInDropdown('insights-tab');

I can't test this on GHE, but checking for the existence of the tab element should fix this.

[fregante]

Thanks, this however silences errors for everyone. If the security tab doesn't existing on GHE, I'd rather see a if !isGHE, onlyShowInDropdown('security-tab')

[busches]

I do not have access to this version of GHE to confirm. Hopefully @orrc or maybe @mrbusche can test.

[cheap-glitch]

Thanks, this however silences errors for everyone. If the security tab doesn't existing on GHE, I'd rather see a if !isGHE, onlyShowInDropdown('security-tab')

Is the "Security" tab never present on GHE? If it's only missing sometimes, how about:

if (!tabItem && isGHE) {
	return;
}

[orrc]

The last couple of versions of the Enterprise docs do mention the "Security tab" as being a thing — it's just not something that appears in any of the many repos I've checked on the one GHE install I have access to.

In any case, I tested this PR and the more-dropdown error is no longer present. 👍

[mrbusche]

On GHE 2.22.6 I'm not seeing the Security tab with or without admin rights.