Lint

.xo-config.json

@@ -16,6 +16,8 @@
 		"no-void": "off",
 		"react/jsx-key": "off",
 		"unicorn/no-array-callback-reference": "off",
+		"@typescript-eslint/no-non-null-assertion": "off",
+		"@typescript-eslint/no-non-null-asserted-optional-chain": "off",
 		"@typescript-eslint/no-extra-non-null-assertion": "error",
 		"@typescript-eslint/consistent-type-definitions": "error",
 		"@typescript-eslint/explicit-function-return-type": [

package.json

@@ -64,7 +64,7 @@
 		"js-abbreviation-number": "^1.1.2",
 		"linkify-issues": "2.0.0-nolookbehind",
 		"linkify-urls": "3.1.0-nolookbehind",
-		"mem": "^8.1.0",
+		"mem": "^8.1.1",
 		"one-event": "^3.0.0",
 		"one-mutation": "^2.0.0",
 		"onetime": "^6.0.0",
@@ -82,23 +82,23 @@
 		"webext-dynamic-content-scripts": "^7.1.1",
 		"webext-options-sync-per-domain": "^2.0.2",
 		"webext-storage-cache": "^4.2.0",
-		"webextension-polyfill": "^0.7.0",
+		"webextension-polyfill": "^0.8.0",
 		"zip-text-nodes": "^1.0.0"
 	},
 	"devDependencies": {
 		"@ava/typescript": "^1.1.1",
 		"@sindresorhus/tsconfig": "^0.9.0",
-		"@types/chrome": "^0.0.134",
-		"@types/codemirror": "^0.0.108",
-		"@types/copy-webpack-plugin": "^6.4.1",
+		"@types/chrome": "^0.0.135",
+		"@types/codemirror": "^0.0.109",
+		"@types/copy-webpack-plugin": "^8.0.0",
 		"@types/firefox-webext-browser": "^82.0.0",
 		"@types/jsdom": "^16.2.10",
-		"@types/mini-css-extract-plugin": "^1.4.1",
+		"@types/mini-css-extract-plugin": "^1.4.2",
 		"@types/react": "^17.0.3",
 		"@types/terser-webpack-plugin": "^5.0.3",
 		"ava": "^3.15.0",
 		"copy-webpack-plugin": "^8.1.1",
-		"css-loader": "^5.2.0",
+		"css-loader": "^5.2.4",
 		"daily-version": "^2.0.0",
 		"dot-json": "^1.2.2",
 		"esbuild-loader": "^2.11.0",
@@ -110,15 +110,15 @@
 		"mini-css-extract-plugin": "^1.4.1",
 		"npm-run-all": "^4.1.5",
 		"size-plugin": "^2.0.2",
-		"stylelint": "^13.12.0",
+		"stylelint": "^13.13.0",
 		"stylelint-config-xo": "^0.20.0",
 		"terser-webpack-plugin": "^5.1.1",
 		"ts-node": "^9.1.1",
 		"tslib": "^2.2.0",
-		"type-fest": "^0.21.3",
+		"type-fest": "^1.0.2",
 		"typed-query-selector": "^2.5.3",
 		"typescript": "^4.2.4",
-		"webpack": "^5.31.0",
+		"webpack": "^5.35.1",
 		"webpack-cli": "^4.6.0",
 		"xo": "^0.38.2"
 	},

source/background.ts

@@ -29,8 +29,8 @@ const messageHandlers = {
 	}
 };
 
-browser.runtime.onMessage.addListener((message, sender) => {
-	for (const id of Object.keys(message ?? {}) as Array<keyof typeof messageHandlers>) {
+browser.runtime.onMessage.addListener((message: typeof messageHandlers, sender) => {
+	for (const id of Object.keys(message) as Array<keyof typeof messageHandlers>) {
 		if (id in messageHandlers) {
 			return messageHandlers[id](message[id], sender);
 		}

source/features/avoid-accidental-submissions.tsx

@@ -8,10 +8,10 @@ function addQuickSubmit(): void {
 	select('input#commit-summary-input')!.classList.add('js-quick-submit');
 }
 
-function onKeyDown(event: delegate.Event<KeyboardEvent, HTMLFormElement>): void {
+function onKeyDown(event: delegate.Event<KeyboardEvent, HTMLInputElement>): void {
 	if (event.key === 'Enter' && !event.ctrlKey) {
 		event.preventDefault();
-		select('#issue_body, #pull_request_body, #commit-description-textarea', event.delegateTarget.form)!.focus();
+		select('#issue_body, #pull_request_body, #commit-description-textarea', event.delegateTarget.form!)!.focus();
 	}
 }
 

source/features/comments-time-machine-links.tsx

@@ -95,7 +95,7 @@ async function showTimemachineBar(): Promise<void | false> {
 			'.repository-content .Box.Box--condensed relative-time',
 			'[itemprop="dateModified"] relative-time' // "Repository refresh" layout
 		].join(), {waitForChildren: false});
-		if (date > lastCommitDate?.attributes.datetime.value!) {
+		if (lastCommitDate && date > lastCommitDate.getAttribute('datetime')!) {
 			return false;
 		}
 

source/features/convert-release-to-draft.tsx

@@ -13,7 +13,7 @@ async function convertToDraft({delegateTarget: draftButton}: delegate.Event): Pr
 
 		const tagName = location.pathname.split('/').pop()!;
 		const release = await api.v3(`releases/tags/${tagName}`);
-		await api.v3(release.url, {
+		await api.v3(String(release.url), {
 			method: 'PATCH',
 			body: {
 				draft: true

source/features/file-finder-buffer.tsx

@@ -20,7 +20,7 @@ const getBufferField = onetime((): HTMLInputElement => (
 ));
 
 function pjaxStartHandler(event: CustomEvent): void {
-	const destinationURL = event.detail?.url;
+	const destinationURL: string = event.detail?.url;
 	if (!destinationURL || !pageDetect.isFileFinder(new URL(destinationURL))) {
 		return;
 	}

source/features/index.tsx

@@ -171,7 +171,7 @@ const checkForHotfixes = cache.function(async () => {
 
 	// eslint-disable-next-line @typescript-eslint/prefer-optional-chain -- https://github.com/typescript-eslint/typescript-eslint/issues/1893
 	if (hotfixes && hotfixes.unaffected) {
-		const currentVersion = browser.runtime.getManifest().version;
+		const currentVersion: string = browser.runtime.getManifest().version;
 		if (compareVersions(hotfixes.unaffected, currentVersion) < 1) {
 			return {};
 		}

source/features/latest-tag-button.tsx

@@ -18,6 +18,16 @@ interface RepoPublishState {
 	aheadBy?: number;
 }
 
+interface Tags {
+	name: string;
+	tag: {
+		oid: string;
+		commit?: {
+			oid: string;
+		};
+	};
+}
+
 const getRepoPublishState = cache.function(async (): Promise<RepoPublishState> => {
 	const {repository} = await api.v4(`
 		repository() {
@@ -58,7 +68,7 @@ const getRepoPublishState = cache.function(async (): Promise<RepoPublishState> =
 	}
 
 	const tags = new Map<string, string>();
-	for (const node of repository.refs.nodes) {
+	for (const node of repository.refs.nodes as Tags[]) {
 		tags.set(node.name, node.tag.commit?.oid ?? node.tag.oid);
 	}
 

source/features/link-to-changelog-file.tsx

@@ -9,6 +9,11 @@ import features from '.';
 import * as api from '../github-helpers/api';
 import {buildRepoURL, getRepo} from '../github-helpers';
 
+interface FileType {
+	name: string;
+	type: string;
+}
+
 const getCacheKey = (): string => `changelog:${getRepo()!.nameWithOwner}`;
 const changelogNames = new Set(['changelog', 'news', 'changes', 'history', 'release', 'whatsnew']);
 
@@ -43,7 +48,7 @@ const getChangelogName = cache.function(async (): Promise<string | false> => {
 	`);
 
 	const files: string[] = [];
-	for (const entry of repository.object.entries) {
+	for (const entry of repository.object.entries as FileType[]) {
 		if (entry.type === 'blob') {
 			files.push(entry.name);
 		}

source/features/list-prs-for-file.tsx

@@ -60,7 +60,7 @@ function getSingleButton(prNumber: number, _?: number, prs?: number[]): HTMLElem
 const getPrsByFile = cache.function(async (): Promise<Record<string, number[]>> => {
 	const {repository} = await api.v4(`
 		repository() {
-			pullRequests(
+			pullRequests (
 				first: 25,
 				states: OPEN,
 				baseRefName: "${await getDefaultBranch()}",

source/features/mark-merge-commits-in-list.tsx

@@ -23,7 +23,7 @@ const filterMergeCommits = async (commits: string[]): Promise<string[]> => {
 	`);
 
 	const mergeCommits = [];
-	for (const [key, commit] of Object.entries<AnyObject>(repository)) {
+	for (const [key, commit] of Object.entries(repository as AnyObject)) {
 		if (commit.parents.totalCount >= 2) {
 			mergeCommits.push(key.slice(1));
 		}

source/features/next-scheduled-github-action.tsx

@@ -31,7 +31,7 @@ const getScheduledWorkflows = cache.function(async (): Promise<Record<string, st
 
 	const schedules: Record<string, string> = {};
 	for (const workflow of workflows) {
-		const workflowYaml = workflow.object.text;
+		const workflowYaml = String(workflow.object.text);
 		const name = /^name[:\s'"]+([^'"\n]+)/m.exec(workflowYaml);
 		const cron = /schedule[:\s-]+cron[:\s'"]+([^'"\n]+)/m.exec(workflowYaml);
 

source/features/quick-repo-deletion.tsx

@@ -42,7 +42,7 @@ async function buttonTimeout(buttonContainer: HTMLDetailsElement): Promise<boole
 	buttonContainer.addEventListener('toggle', () => {
 		abortController.abort();
 	}, {once: true});
-
+	// eslint-disable-next-line promise/prefer-await-to-then
 	void api.expectTokenScope('delete_repo').catch((error: Error) => {
 		abortController.abort();
 		buttonContainer.open = false;

source/features/release-download-count.tsx

@@ -8,6 +8,11 @@ import {abbreviateNumber} from 'js-abbreviation-number';
 import features from '.';
 import * as api from '../github-helpers/api';
 
+interface ReleaseAssets {
+	releaseAssets: {
+		nodes: Asset[];
+	};
+}
 interface Asset {
 	name: string;
 	downloadCount: number;
@@ -31,15 +36,15 @@ async function getAssetsForTag(tags: string[]): Promise<Tag> {
 	`);
 
 	const assets: Tag = {};
-	for (const [tag, release] of Object.entries(repository)) {
-		assets[tag] = (release as AnyObject).releaseAssets.nodes;
+	for (const [tag, release] of Object.entries(repository as ReleaseAssets[])) {
+		assets[tag] = release.releaseAssets.nodes;
 	}
 
 	return assets;
 }
 
 async function init(): Promise<void | false> {
-	const releases = new Map();
+	const releases = new Map<string, HTMLElement>();
 	for (const release of select.all('.release')) {
 		if (select.exists('.octicon-package', release)) {
 			const name = select('svg.octicon-tag ~ span', release)!.textContent!;

source/features/repo-age.tsx

@@ -10,6 +10,15 @@ import features from '.';
 import * as api from '../github-helpers/api';
 import {getRepo} from '../github-helpers';
 
+interface CommitTarget {
+	oid: string;
+	committedDate: string;
+	resourcePath: string;
+	history: {
+		totalCount: number;
+	};
+}
+
 const fresh = [
 	'Freshly baked',
 	'Freshly brewed',
@@ -50,7 +59,7 @@ const getRepoAge = async (commitSha: string, commitsCount: number): Promise<[com
 	const {committedDate, resourcePath} = repository.defaultBranchRef.target.history.nodes
 		.reverse()
 		// Filter out any invalid commit dates #3185
-		.find((commit: AnyObject) => new Date(commit.committedDate).getFullYear() > 1970);
+		.find((commit: CommitTarget) => new Date(commit.committedDate).getFullYear() > 1970);
 
 	return [committedDate, resourcePath];
 };
@@ -73,7 +82,7 @@ const getFirstCommit = cache.function(async (): Promise<[committedDate: string,
 		}
 	`);
 
-	const {oid: commitSha, history, committedDate, resourcePath} = repository.defaultBranchRef.target;
+	const {oid: commitSha, history, committedDate, resourcePath} = repository.defaultBranchRef.target as CommitTarget;
 	const commitsCount = history.totalCount;
 	if (commitsCount === 1) {
 		return [committedDate, resourcePath];

source/features/show-associated-branch-prs-on-fork.tsx

@@ -10,6 +10,9 @@ import * as api from '../github-helpers/api';
 import {getRepo, upperCaseFirst} from '../github-helpers';
 
 interface PullRequest {
+	timelineItems: {
+		nodes: AnyObject;
+	};
 	number: number;
 	state: keyof typeof stateClass;
 	isDraft: boolean;
@@ -42,11 +45,11 @@ const getPullRequestsAssociatedWithBranch = cache.function(async (): Promise<Rec
 
 	const pullRequests: Record<string, PullRequest> = {};
 	for (const {name, associatedPullRequests} of repository.refs.nodes) {
-		const [prInfo] = associatedPullRequests.nodes;
+		const [prInfo] = associatedPullRequests.nodes as PullRequest[];
 		// Check if the ref was deleted, since the result includes pr's that are not in fact related to this branch but rather to the branch name.
 		const headRefWasDeleted = prInfo?.timelineItems.nodes[0]?.__typename === 'HeadRefDeletedEvent';
 		if (prInfo && !headRefWasDeleted) {
-			prInfo.state = prInfo.isDraft && prInfo.state === 'OPEN' ? 'Draft' : upperCaseFirst(prInfo.state);
+			prInfo.state = prInfo.isDraft && upperCaseFirst(prInfo.state) === 'Open' ? 'Draft' : upperCaseFirst(prInfo.state) as keyof typeof stateClass;
 			pullRequests[name] = prInfo;
 		}
 	}

source/features/stop-redirecting-in-notification-bar.tsx

@@ -3,9 +3,13 @@ import delegate from 'delegate-it';
 
 import features from '.';
 
+interface SessionStorage extends Storage {
+	notification_shelf: string;
+}
+
 const hasNotificationBar = (): boolean =>
 	location.search.startsWith('?notification_referrer_id=') ||
-	JSON.parse(sessionStorage.notification_shelf ?? '{}').pathname === location.pathname;
+	JSON.parse((sessionStorage as SessionStorage).notification_shelf ?? '{}').pathname === location.pathname;
 
 function handleClick(event: delegate.Event<MouseEvent, HTMLButtonElement>): void {
 	// Disable the redirect to the Notifications inbox if either:

source/options.tsx

@@ -6,6 +6,7 @@ import domify from 'doma';
 import select from 'select-dom';
 import delegate from 'delegate-it';
 import fitTextarea from 'fit-textarea';
+import {JsonObject} from 'type-fest';
 import * as indentTextarea from 'indent-textarea';
 
 import {perDomainOptions} from './options-storage';
@@ -53,8 +54,8 @@ async function getTokenScopes(personalToken: string): Promise<string[]> {
 	});
 
 	if (!response.ok) {
-		const details = await response.json();
-		throw new Error(details.message);
+		const details: JsonObject = await response.json();
+		throw new Error(String(details.message));
 	}
 
 	const scopes = response.headers.get('X-OAuth-Scopes')!.split(', ');
@@ -157,7 +158,7 @@ function featuresFilterHandler(event: Event): void {
 
 async function highlightNewFeatures(): Promise<void> {
 	const {featuresAlreadySeen} = await browser.storage.local.get({featuresAlreadySeen: {}});
-	const isFirstVisit = Object.keys(featuresAlreadySeen).length === 0;
+	const isFirstVisit = Object.keys(featuresAlreadySeen as AnyObject).length === 0;
 	const tenDaysAgo = Date.now() - (10 * 24 * 60 * 60 * 1000);
 
 	for (const feature of select.all('.feature [type=checkbox]')) {