Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplication and cropped hovercard in user-local-time #4384

Merged
merged 8 commits into from Jun 3, 2021
Merged

Fix duplication and cropped hovercard in user-local-time #4384

merged 8 commits into from Jun 3, 2021

Conversation

cheap-glitch
Copy link
Member

@cheap-glitch cheap-glitch commented May 22, 2021 •
edited

Fixes #3634
Fixes #4345

Test URLs

Steps to reproduce the bug:

  1. Clear the extension cache
  2. Go to a page with a lot of usernames, e.g. https://github.com/sindresorhus/refined-github/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc
  3. Hover over the various usernames until the bug appears (it may take a while)

For #4345: https://github.com/hexalellogram/iPhoneBatteryClient

Screenshot

capture-1622648311.mp4

For the comment in the CSS:
image

@yakov116 yakov116 added the bug label May 23, 2021
@fregante fregante marked this pull request as draft May 26, 2021 18:53
@cheap-glitch

This comment has been minimized.

Sign in to view
@yakov116
Copy link
Member

yakov116 commented Jun 2, 2021

Yes

@yakov116
Copy link
Member

yakov116 commented Jun 2, 2021

Maybe its just me. But do you get the feeling the the init function should be split into 2?

@cheap-glitch @yakov116
Update source/features/user-local-time.tsx
3120b66 
Indicate element type in selector

Co-authored-by: yakov116 <16872793+yakov116@users.noreply.github.com>
@cheap-glitch

This comment has been minimized.

Sign in to view
@cheap-glitch cheap-glitch marked this pull request as ready for review June 2, 2021 15:49
@cheap-glitch cheap-glitch changed the title Fix rare duplication in user-local-time Fix duplication and cropped hovercard in user-local-time Jun 2, 2021
@yakov116
Copy link
Member

yakov116 commented Jun 3, 2021

LGTM

@yakov116 yakov116 requested a review from fregante June 3, 2021 02:58
@yakov116 yakov116 merged commit 54edc01 into refined-github:main Jun 3, 2021
@yakov116
Copy link
Member

yakov116 commented Jun 3, 2021

@cheap-glitch thanks for all your great work!

@cheap-glitch cheap-glitch deleted the fix-local-user-time branch June 3, 2021 13:10
@fregante
Copy link
Member

fregante commented Jun 4, 2021

🙌 2 bugs in 1!

@cheap-glitch cheap-glitch mentioned this pull request Jun 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yakov116 yakov116 yakov116 left review comments

@fregante fregante Awaiting requested review from fregante

Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Profile hover info is cut off user-local-time occasionally appears twice
3 participants
@cheap-glitch @yakov116 @fregante