Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplication and cropped hovercard in user-local-time #4384

Merged
merged 8 commits into from
Jun 3, 2021
Merged

Fix duplication and cropped hovercard in user-local-time #4384

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
19e1aad
Fix rare duplication in `user-local-time`
cheap-glitch May 22, 2021
4442fb2
Use `selector-observer` to de-duplicate handler calls
cheap-glitch Jun 2, 2021
ca3acf3
Don't add dedup class too soon
cheap-glitch Jun 2, 2021
5964125
Reserve space in hovercard using CSS
cheap-glitch Jun 2, 2021
3120b66
Update source/features/user-local-time.tsx
cheap-glitch Jun 2, 2021
5c47730
Move callback to top level
cheap-glitch Jun 2, 2021
61fb9b9
Link to explanatory screenshot in comment
cheap-glitch Jun 2, 2021
0d422d9
Merge branch 'main' into fix-local-user-time
yakov116 Jun 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions source/features/user-local-time.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,9 @@ function parseOffset(date: string): number {
function init(): void {
const hovercard = select('.js-hovercard-content > .Popover-message')!;

observeElement(hovercard, async () => {
observeElement(hovercard, async ([mutation]) => {
if (
select.exists('.rgh-local-user-time', hovercard) || // Time already added
cheap-glitch marked this conversation as resolved.
Show resolved Hide resolved
mutation?.addedNodes?.length !== 1 || // Avoid duplicated time element issue #3634
fregante marked this conversation as resolved.
Show resolved Hide resolved
!select.exists('[data-hydro-view*="user-hovercard-hover"]', hovercard) // It's not the hovercard type we expect
) {
return;
Expand Down