Clean up more parse-backticks selectors
#4819
Conversation
The working selector is added in refined-github@6d1fef4
|
Can anyone help with testing if this is still needed? |
kidonng
force-pushed
the
parse-backticks
branch
from
5adaa2e
to
3db6e3b
Compare
|
I see you removed some code for the repo search. Please provide a real URL to make sure the issue does not happen. |
| '.issues_labeled .text-gray-dark > a', // `isDashboard` "help wanted" event titles (GHE #4021) | ||
| '.issues_labeled .color-text-primary > a', // `isDashboard` "help wanted" event titles |
There was a problem hiding this comment.
Can anyone help with testing if this is still needed?
Unfortunately I don't have any help wanted on the feed at the moment. If you follow me I just added a help wanted label on a RG issue though
There was a problem hiding this comment.
If you follow me I just added a
help wantedlabel on a RG issue though
Of course I'm going to follow you, even if it's not for the label! Again, wondering why I didn't do this before.
There was a problem hiding this comment.
Label added, you should see it now
| @@ -52,14 +33,6 @@ function init(): void { | |||
| parseBackticks(element); | |||
| }, | |||
| }); | |||
|
|
|||
| // `isRepoSearch` might highlight keywords inside backticks, breaking the regular dom-formatter #3509 | |||
There was a problem hiding this comment.
I see you removed some code for the repo search. Please provide a real URL to make sure the issue does not happen.
👍 Checked and added link to first post. GitHub does it natively now https://github.com/sindresorhus/refined-github/search?q=latest+reliable+button+is%3Aissue&type=Issues
|
Added a help wanted |
I thought I did? Maybe that's another PR, sorry for that 😄 |
It seems titles are mostly parsed by GitHub however commits (especially description) are not.
|
I will merge this within 24 hours |
Related #4135
We only cleaned up the selectors a little bit in
5e40087(#4361) but there's plenty more to deal with. I started with removing all "commit" related selector since they should all be native now.Test URLs
(Too many places 🤷♀️ just test and see if there are places left out)
isActionsrun: https://github.com/sindresorhus/refined-github/actions/runs/1272877098isRepoSearch: https://github.com/sindresorhus/refined-github/search?q=latest+reliable+button+is%3Aissue&type=IssuesScreenshot