Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate same-branch-author-commits #5313

Merged
merged 2 commits into from
Jan 17, 2022
Merged

Conversation

kidonng
Copy link
Member

@kidonng kidonng commented Jan 15, 2022

Somehow I didn't write deduplicate in #5289 and same-branch-author-commits doesn't work if you go to "Commits" page from repo tree.

I also just noticed this feature also keeps the current file path for us, which is a huge deal.

Test URLs

https://github.com/refined-github/refined-github/commits/main/.github

Screenshot

N/A

@kidonng kidonng added the bug label Jan 15, 2022
@@ -324,7 +324,7 @@ Thanks for contributing! 🦋🙌
- [](# "deep-reblame") [When exploring blames, `Alt`-clicking the “Reblame” buttons will extract the associated PR’s commits first, instead of treating the commit a single change.](https://user-images.githubusercontent.com/16872793/77248541-8e3f2180-6c10-11ea-91d4-221ccc0ecebb.png)
- [](# "highlight-deleted-and-added-files-in-diffs") [Indicates with an icon whether files in commits and pull requests being added or removed.](https://user-images.githubusercontent.com/1402241/90332474-23262b00-dfb5-11ea-9a03-8fd676ea0fdd.png)
- [](# "easy-toggle-files") [Enables toggling file diffs by clicking on their header bar.](https://user-images.githubusercontent.com/47531779/99855419-be173e00-2b7e-11eb-9a55-0f6251aeb0ef.gif)
- [](# "same-branch-author-commits") [Enables viewing all commits by an author on the same branch you are viewing.](https://user-images.githubusercontent.com/44045911/148764372-ee443213-e61a-4227-9219-0ee54ed832e8.png)
- [](# "same-branch-author-commits") [Preserves current branch and path when viewing all commits by an author.](https://user-images.githubusercontent.com/44045911/148764372-ee443213-e61a-4227-9219-0ee54ed832e8.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I was thinking about renaming it... maybe same-view-author-commits? Doesn't really matter though

@kidonng kidonng merged commit 82fb3d6 into main Jan 17, 2022
@kidonng kidonng deleted the dedup-same-branch-author-commits branch January 17, 2022 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants