Extend clean-conversations to new comment forms
#5315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheap-glitch
changed the title
clean-conversations: enable on conversationsclean-conversations to new comment forms
fregante
previously approved these changes
Jan 17, 2022
fregante
reviewed
Jan 17, 2022
| display: none; | ||
| } | ||
|
|
||
| .review-thread-reply .review-thread-reply-button { | ||
| margin-left: 0; | ||
| } | ||
|
|
||
| /* Hide arrow on new comment form */ | ||
| .timeline-comment--caret::before, |
There was a problem hiding this comment.
Does this really only target the form? The selector is generic
There was a problem hiding this comment.
Good catch, this was done in a hurry in my previous lint PR 😅
kidonng
commented
Jan 17, 2022
Comment on lines
-38
to
-46
| /* Remove user avatar from new comment form on threads */ | ||
| .review-thread-reply .avatar { | ||
| display: none; | ||
| } | ||
|
|
||
| .review-thread-reply .review-thread-reply-button { | ||
| margin-left: 0; | ||
| } | ||
|
|
There was a problem hiding this comment.
Apparently forgotten in f099d37 (#1986)
kidonng
commented
Jan 17, 2022
| /* Remove user avatar from new comment form on threads */ | ||
| .review-thread-reply .avatar { | ||
| /* Remove user avatar from new comment form */ | ||
| :is(.review-thread-reply, .timeline-new-comment) .avatar { |
There was a problem hiding this comment.
- Despite the name,
.review-thread-replyis also used in Discussions thread reply (could it be that they are review comments in disguise? 🤔) .timeline-new-commentworks on both conversations and commits page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from
84c9dc1(#5113)Mentioned in #1066
Test URLs
Screenshot