(WIP) Bunch of code shortcuts #576
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
changed the title
|
@bfred-it After this, can you take a break from the de-jQuery stuff? It creates a lot of review work for very little gain. Using jQuery is fine in most cases, it's just in the hot-paths we should be careful. A lot of this feels like premature optimizations and churn. |
|
Yeah sometimes I get carried away 😅 |
|
Let's wait for #558 to be in first, some pieces overlap. Don't test yet. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started as a de-jquerification PR like #448, ended up shortening a lot of functions.
The code changes are best read one commit at a time, but can be tried all at once.
Sorry for not pushing all of these separately but I felt that checking each one out separately would be just too much to ask since there's no new functionality added.