Restore clean-header-search-field for some users
#6311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works for me! |
yakov116
reviewed
Feb 8, 2023
| const headerSearchButton = await elementReady('button.header-search-button, input.header-search-input'); | ||
| if (headerSearchButton instanceof HTMLInputElement) { | ||
| // Previous version #6310 | ||
| // TODO: Remove in mid 2023 |
There was a problem hiding this comment.
Maybe put a real date so it shows up as a warning
There was a problem hiding this comment.
I know we've been doing that, but what does that change in practice? We don't want CI to start failing and force us to immediately take action 🤔
There was a problem hiding this comment.
If I am not mistaken we set it to warn
There was a problem hiding this comment.
We did, but due to:
I think expiring-todo-comments only makes sense:
- if it never breaks (on a date) and forces anyone to act immediately
- if someone is actively looking for and fixing TODO comments
- if there are no other TODOs that are also waiting for a fix anyway, for months
Essentially I think we can do away with them. Moving this discussion upstream in sindresorhus/eslint-plugin-unicorn#1541
It should be toggleable in the feature preview settings:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clean-header-search-field: Cannot read properties of undefined (reading 'classList') #6310Test URLs
https://github.com/fregante/GhostText/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc
Screenshot
Untested, depends on the user
cc @kaste