Enable reaction-avatars on organization discussions
#6316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
commented
Feb 9, 2023
| @@ -58,7 +58,8 @@ const viewportObserver = new IntersectionObserver(changes => { | |||
| }); | |||
|
|
|||
| function showAvatarsOn(commentReactions: Element): void { | |||
| const avatarLimit = arbitraryAvatarLimit - (commentReactions.children.length * approximateHeaderLength); | |||
| const reactionTypes = select.all('.social-reaction-summary-item', commentReactions).length; | |||
| const avatarLimit = arbitraryAvatarLimit - (reactionTypes * approximateHeaderLength); | |||
There was a problem hiding this comment.
The DOM was updated to use tool-tip elements, but just on organization discussions apparently.
| function observeCommentReactions(commentReactions: Element): void { | ||
| commentReactions.classList.add('rgh-reactions'); |
There was a problem hiding this comment.
Outdated since the new observer has been added
| awaitDomReady: false, | ||
| init, | ||
| }, { | ||
| include: [ |
There was a problem hiding this comment.
No separation needed since we dropped the comments listener attached to hasComments
| @@ -74,35 +75,30 @@ function showAvatarsOn(commentReactions: Element): void { | |||
| } | |||
| } | |||
|
|
|||
| // TODO [2022-12-18]: Drop `.comment-reactions-options` (GHE) | |||
| const reactionsSelector = '.has-reactions :is(.js-comment-reactions-options, .comment-reactions-options):not(.rgh-reactions)'; | |||
There was a problem hiding this comment.
Outdated, related:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reaction-avatarsdoesn't work on Discussions #5485Org discussions
https://github.com/orgs/community/discussions/11202
Regular discussions
parcel-bundler/parcel#6490
PRs
#4119