linkify-code - Fix issue links on global search pages
#7005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
reviewed
Oct 31, 2023
fregante
reviewed
Nov 1, 2023
| linkifyIssues(currentRepo, element); | ||
| } | ||
| const currentRepo = pageDetect.isGlobalSearchResults() | ||
| ? getRepo(wrapper.parentElement!.querySelector('.blob-num a')!.href) |
There was a problem hiding this comment.
Are you sure this works? The wrapper seems to be a td, so the parentElement is a tr, which does not contain any links.
The right ancestor is probably Box-sc-g0xbh4-0 kNKjla, which is hard to target 😬
There was a problem hiding this comment.
The selector targets the line link, rather than the repo link at the top of each file.
tr (parent) .blob-num a seems to work properly, seeing as the hovercard shows (screenshot ^)
There was a problem hiding this comment.
Oh neat, I thought it was targeting the file header
fregante
changed the title
linkify-code - Fix on search pageslinkify-code - Fix issue links on global search pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6996
Retrieves the repository using the line url when getRepo doesn't work
/notion-enhancer/notion-repackaged/blob/4eefa99dc1bcde18268d70bb2b7f050786229feb/scripts/extract-src.sh#L50↑ pull repo from this
Test URLs
https://github.com/search?q=repo%3Anotion-enhancer%2Fnotion-repackaged%20sqlite&type=code
https://github.com/search?q=org%3Arefined-github+%2F%23%5Cd%2B%2F&type=code
https://github.com/search?q=%2F%23%5Cd%7B4%2C%7D%2F+language%3Atypescript&type=code
Screenshot