Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

one-click-review-submission - Restore feature #7015

Merged
merged 3 commits into from
Nov 1, 2023
Merged

one-click-review-submission - Restore feature #7015

merged 3 commits into from
Nov 1, 2023

Conversation

tanmayrajani
Copy link
Contributor

Fixes #7010

  • changed the selector to use .parentElement instead of .closest('.form-actions') since it looks like there's no .form-actions anymore

Test URLs

Any open PR URLs where you have access to review the changes

e.g. #7005

Screenshot

image

with tooltip
image

@tanmayrajani tanmayrajani marked this pull request as ready for review November 1, 2023 06:32
fregante
fregante reviewed Nov 1, 2023
View reviewed changes
Copy link
Member

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! Unfortunately I think this will break GitHub Enterprise. The solution just be to use ['.form-actions', '.Overlay-footer'].

The array style will allow for comments to specify that the first one only exists for compat

@fregante fregante added the bug label Nov 1, 2023
fregante
fregante approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this works I'll merge it today and release a new version

@fregante fregante changed the title one-click-review-submission - Fix selector one-click-review-submission - Restore feature Nov 1, 2023
busches
busches approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@busches busches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this is still working on GHE 3.9.4

@fregante fregante merged commit 3131acf into refined-github:main Nov 1, 2023
10 checks passed
@fregante
Copy link
Member

fregante commented Nov 1, 2023 •
edited

Thank you @tanmayrajani and @busches!

@bartgol
Copy link

bartgol commented Nov 1, 2023

Thanks! Side question: do you know how long it usually takes for a new release to make it to the Chrome extensions store? Days? Weeks?

@fregante
Copy link
Member

fregante commented Nov 1, 2023

Usually minutes, but occasionally hours. Every year or 2 years it's blocked for further review. If you don't see it tomorrow we can ping Sindre

@madsnedergaard
Copy link

It's out and works for me after clearing cache in extension settings :)

@tanmayrajani tanmayrajani deleted the fix-one-click-review-submission-selector branch November 2, 2023 09:30
@fregante fregante mentioned this pull request Nov 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busches busches busches approved these changes

@fregante fregante fregante approved these changes

Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

one-click-review-submission gone?
5 participants
@tanmayrajani @fregante @bartgol @madsnedergaard @busches