Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Specific Toolbar items #872

Merged
merged 4 commits into from
Dec 13, 2017

Conversation

yakov116
Copy link
Member

@yakov116 yakov116 commented Dec 13, 2017

Closes #779
@bfred-it Like this?

@fregante
Copy link
Member

They're all still there for me

screen shot 2017-12-13 at 23 21 50

/*Add Some Spacing*/
.js-saved-reply-container, .toolbar-item[data-prefix="- "]{
padding-left: 15px !important;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation

}
}
/*Add Some Spacing*/
.js-saved-reply-container, .toolbar-item[data-prefix="- "]{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space before {

display: none;
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation

@@ -122,9 +122,15 @@
.toolbar-group:last-child {
display: inline-block;
}
.toolbar-group .toolbar-item:not(.js-saved-reply-container):not(.rgh-upload-btn) {
./* Hide Specific toolbar items*/
.toolbar-group .toolbar-item[data-prefix="@"], .toolbar-item[data-prefix="#"], .toolbar-group:first-child, .toolbar-item[data-prefix="`"] {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Break after each ,

@@ -122,9 +122,15 @@
.toolbar-group:last-child {
display: inline-block;
}
.toolbar-group .toolbar-item:not(.js-saved-reply-container):not(.rgh-upload-btn) {
./* Hide Specific toolbar items*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra . that shouldn't be there.

display: none;
}
}
/*Add Some Spacing*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments:

  • only the first letter should be capitalized
  • spaces after /* and before */

Copy link
Member

@fregante fregante Dec 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalization still incorrect on both comments

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should it be?
I dont know how to do it but it would be nice to add to the below

image

@yakov116
Copy link
Member Author

@bfred-it
image

Can you edit it for me? I'm at work...

@yakov116
Copy link
Member Author

@bfred-it is it working by you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants