fix(core): useMenu's default value of hideOnMissingParameter prop (#…

…5884)

.changeset/weak-impalas-relate.md

@@ -0,0 +1,7 @@
+---
+"@refinedev/core": patch
+---
+
+fix(core): `useMenu` `hideOnMissingParameter` prop default value set to `true`
+
+There was an error in the `useMenu` hook's `hideOnMissingParameter` prop. Its default value should be `true` but it was missed when props are passed partially. This PR fixes the issue by setting the default value to `true`.

packages/core/src/hooks/menu/useMenu.spec.tsx

@@ -390,7 +390,59 @@ describe("useMenu Hook", () => {
     );
   });
 
-  it("should hide item if parameter is missing", async () => {
+  it("should hide item if parameter is missing by default", async () => {
+    const { result } = renderHook(() => useMenu(), {
+      wrapper: TestWrapper({
+        resources: legacyResourceTransform([
+          {
+            name: "visible",
+            list: () => null,
+          },
+          {
+            name: "org-users",
+            list: "orgs/:orgId/users",
+          },
+        ]),
+      }),
+    });
+
+    expect(result.current.menuItems).toEqual(
+      expect.arrayContaining([expect.objectContaining({ name: "visible" })]),
+    );
+    expect(result.current.menuItems).toEqual(
+      expect.not.arrayContaining([
+        expect.objectContaining({ name: "org-users" }),
+      ]),
+    );
+  });
+
+  it("should hide item if parameter is missing by partial props", async () => {
+    const { result } = renderHook(() => useMenu({ meta: {} }), {
+      wrapper: TestWrapper({
+        resources: legacyResourceTransform([
+          {
+            name: "visible",
+            list: () => null,
+          },
+          {
+            name: "org-users",
+            list: "orgs/:orgId/users",
+          },
+        ]),
+      }),
+    });
+
+    expect(result.current.menuItems).toEqual(
+      expect.arrayContaining([expect.objectContaining({ name: "visible" })]),
+    );
+    expect(result.current.menuItems).toEqual(
+      expect.not.arrayContaining([
+        expect.objectContaining({ name: "org-users" }),
+      ]),
+    );
+  });
+
+  it("should hide item if parameter is missing if set explicitly", async () => {
     const { result } = renderHook(
       () => useMenu({ hideOnMissingParameter: true }),
       {

packages/core/src/hooks/menu/useMenu.tsx

@@ -46,7 +46,7 @@ const getCleanPath = (pathname: string) => {
  * @see {@link https://refine.dev/docs/api-reference/core/hooks/ui/useMenu} for more details.
  */
 export const useMenu = (
-  { meta, hideOnMissingParameter }: UseMenuProps = {
+  { meta, hideOnMissingParameter = true }: UseMenuProps = {
     hideOnMissingParameter: true,
   },
 ): UseMenuReturnType => {