Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: internal packages dependencies #2217

Merged
merged 3 commits into from Jul 26, 2022
Merged

Conversation

omeraplak
Copy link
Member

Please provide enough information so that others can review your pull request:

All of the refine packages have dependencies on the @pankod/refine-core package. So far we have managed these dependencies with peerDependencies + dependencies but this causes issues like #2183. (having more than one @pankod/refine-core version in node_modules and creating different instances)

Managing as peerDependencies + devDependencies seems like the best way for now to avoid such issues.

Closing issues

Self Check before Merge

Please check all items below before review.

  • Corresponding issues are created/updated or not needed
  • Docs are updated/provided or not needed
  • Examples are updated/provided or not needed
  • TypeScript definitions are updated/provided or not needed
  • Tests are updated/provided or not needed
  • Changesets are provided or not needed

@changeset-bot
Copy link

changeset-bot bot commented Jul 26, 2022

🦋 Changeset detected

Latest commit: c0d0fd1

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c0d0fd1:

Sandbox Source
fine-foods Configuration
fine-foods-client Configuration
mui-fine-foods Configuration

@refine-bot
Copy link
Contributor

refine-bot commented Jul 26, 2022

♻️ PR Preview c0d0fd1 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@refine-bot
Copy link
Contributor

refine-bot commented Jul 26, 2022

♻️ PR Preview c0d0fd1 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@omeraplak omeraplak merged commit b4aae00 into next Jul 26, 2022
@omeraplak omeraplak deleted the fix/internal-dependencies branch July 26, 2022 12:26
@refine-bot
Copy link
Contributor

😭 Deploy PR Preview c0d0fd1 failed. Build logs

🤖 By surge-preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants