fix(useShow): Pass queryOptions correctly through useShow hook #3073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: dc80828 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for refine-doc-live-previews ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
samelhusseini
changed the title
aliemir
approved these changes
Nov 28, 2022
This was referenced Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent PR #3030 added a feature to accept queryOptions as a parameter to the
useShowhook. It however was not passed in correctly through theuseShowhook to theuseOnehook (spread in the useOne props bag instead of the queryOptions bag, see further details in #3072.Change fixes the bug.
Test plan (required)
Tests pass.
Verified locally that the queryOptions are passed through to
useOnefromuseShow.Closing issues
closes #3072
Self Check before Merge
Please check all items below before review.