chore: restore filter operator after clearing on filter dropdown #3224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 14, 2022 08:34
🦋 Changeset detectedLatest commit: d6bba66 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for refine-doc-live-previews ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
alicanerdurmaz
approved these changes
Dec 14, 2022
omeraplak
approved these changes
Dec 14, 2022
alicanerdurmaz
approved these changes
Dec 14, 2022
This was referenced Dec 14, 2022
leapful
deleted the
bugfix/issue-1386/restore-filter-operator-after-clear-filter-dropdown
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the details for making this change. What existing problem does the pull request solve?
By default, "Clear" action from Filter Dropdown is handled by Ant Design by removing filter column value out from list filter. If there is a new value on the filter column again, the mapping has no context on initial filters to restore correct operator.
By providing a map of initial filters, mapping new filters can restore operator in case previous filters is empty or no data on target filter column.
Test plan (required)
{ field: 'title', operator: 'contains', value: '' }Closing issues
closes #1386
Self Check before Merge
Please check all items below before review.