Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inferencer): assumes id is number in custom pages #4427

Merged
merged 2 commits into from
Jun 1, 2023

Conversation

alicanerdurmaz
Copy link
Member

  • fixed: Inferencer assumes id is number in custom pages.
    From now on, if id is typeof string, and inferencer will infer it as string.
  • snapshot tests updated

Test plan (required)

image

Closing issues

closes #4390

Self Check before Merge

Please check all items below before review.

  • Corresponding issues are created/updated or not needed
  • Docs are updated/provided or not needed
  • Examples are updated/provided or not needed
  • TypeScript definitions are updated/provided or not needed
  • Tests are updated/provided or not needed
  • Changesets are provided or not needed

@changeset-bot
Copy link

changeset-bot bot commented May 31, 2023

🦋 Changeset detected

Latest commit: d00c8a2

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented May 31, 2023

Deploy Preview for lighthearted-pastelito-e86ad1 ready!

Name Link
🔨 Latest commit d00c8a2
🔍 Latest deploy log https://app.netlify.com/sites/lighthearted-pastelito-e86ad1/deploys/64774ba04cecfc0008b8c13e
😎 Deploy Preview https://deploy-preview-4427--lighthearted-pastelito-e86ad1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 31, 2023

Deploy Preview for refine-doc-live-previews ready!

Name Link
🔨 Latest commit d00c8a2
🔍 Latest deploy log https://app.netlify.com/sites/refine-doc-live-previews/deploys/64774ba0582d9d00085fb0d9
😎 Deploy Preview https://deploy-preview-4427--refine-doc-live-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 31, 2023

Deploy Preview for stupendous-taffy-33f80c ready!

Name Link
🔨 Latest commit d00c8a2
🔍 Latest deploy log https://app.netlify.com/sites/stupendous-taffy-33f80c/deploys/64774ba009bb40000816c2fd
😎 Deploy Preview https://deploy-preview-4427--stupendous-taffy-33f80c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 31, 2023

Deploy Preview for imaginative-sundae-1fd394 ready!

Name Link
🔨 Latest commit d00c8a2
🔍 Latest deploy log https://app.netlify.com/sites/imaginative-sundae-1fd394/deploys/64774ba00410630008ccc056
😎 Deploy Preview https://deploy-preview-4427--imaginative-sundae-1fd394.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 31, 2023

Deploy Preview for aquamarine-panda-e208bf ready!

Name Link
🔨 Latest commit d00c8a2
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-panda-e208bf/deploys/64774ba0414d9900089d800d
😎 Deploy Preview https://deploy-preview-4427--aquamarine-panda-e208bf.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nx-cloud
Copy link

nx-cloud bot commented May 31, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d00c8a2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 46 targets

Sent with 💌 from NxCloud.

@BatuhanW BatuhanW requested a review from aliemir May 31, 2023 14:50
@omeraplak omeraplak added this pull request to the merge queue Jun 1, 2023
Merged via the queue into next with commit b429816 Jun 1, 2023
40 checks passed
@omeraplak omeraplak deleted the fix/inferencer-id-value-in-custom-pages branch June 7, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Inferencer assumes id is number
6 participants