Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: react hook form type issues after recent release #4551

Merged
merged 8 commits into from
Jun 19, 2023

Conversation

BatuhanW
Copy link
Member

react-hook-form recently published a release which broke our examples. Probably related to this PR react-hook-form/react-hook-form#10342

This PR fixes type issues related to recent change.

@BatuhanW BatuhanW self-assigned this Jun 19, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jun 19, 2023

⚠️ No Changeset found

Latest commit: 546137b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jun 19, 2023

Deploy Preview for lighthearted-pastelito-e86ad1 ready!

Name Link
🔨 Latest commit 546137b
🔍 Latest deploy log https://app.netlify.com/sites/lighthearted-pastelito-e86ad1/deploys/64909a8cf970b60008856606
😎 Deploy Preview https://deploy-preview-4551--lighthearted-pastelito-e86ad1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 19, 2023

Deploy Preview for refine-doc-live-previews ready!

Name Link
🔨 Latest commit 546137b
🔍 Latest deploy log https://app.netlify.com/sites/refine-doc-live-previews/deploys/64909a8cbcef3d000815e7ed
😎 Deploy Preview https://deploy-preview-4551--refine-doc-live-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 19, 2023

Deploy Preview for stupendous-taffy-33f80c ready!

Name Link
🔨 Latest commit 546137b
🔍 Latest deploy log https://app.netlify.com/sites/stupendous-taffy-33f80c/deploys/64909a8d382f8f00082b306e
😎 Deploy Preview https://deploy-preview-4551--stupendous-taffy-33f80c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 19, 2023

Deploy Preview for aquamarine-panda-e208bf ready!

Name Link
🔨 Latest commit 546137b
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-panda-e208bf/deploys/64909a8caee14f000877589a
😎 Deploy Preview https://deploy-preview-4551--aquamarine-panda-e208bf.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 19, 2023

Deploy Preview for imaginative-sundae-1fd394 ready!

Name Link
🔨 Latest commit 546137b
🔍 Latest deploy log https://app.netlify.com/sites/imaginative-sundae-1fd394/deploys/64909a8c246201000805d09b
😎 Deploy Preview https://deploy-preview-4551--imaginative-sundae-1fd394.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nx-cloud
Copy link

nx-cloud bot commented Jun 19, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 546137b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


🟥 Failed Commands
lerna run cypress:run --scope form-material-ui-use-modal-form
lerna run cypress:run --scope form-antd-mutation-mode
✅ Successfully ran 42 targets

Sent with 💌 from NxCloud.

@aliemir aliemir enabled auto-merge June 19, 2023 18:14
@BatuhanW BatuhanW requested a review from aliemir June 19, 2023 18:16
@BatuhanW BatuhanW disabled auto-merge June 19, 2023 18:31
@BatuhanW BatuhanW merged commit 1069305 into next Jun 19, 2023
38 of 39 checks passed
@BatuhanW BatuhanW deleted the fix-type-issues-with-react-hook-form branch June 19, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant