Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update @tabler/icons dependency #4975

Merged
merged 2 commits into from Sep 20, 2023
Merged

Conversation

aliemir
Copy link
Member

@aliemir aliemir commented Sep 20, 2023

There are some versions between the defined version (v1.1.0) and the latest in the range (v1.119.0) which are not fully compatible with our usage by missing icons or due to changes in the configuration. Recently had this issue reported at #4921

We're updating our @tabler/icons dependency to v1.119.0 to make sure the package managers are installing a properly working version with our packages.

In the future, we're planning to move to v2 of @tabler/icons to follow the latest version.

Self Check before Merge

Please check all items below before review.

  • Corresponding issues are created/updated or not needed
  • Docs are updated/provided or not needed
  • Examples are updated/provided or not needed
  • TypeScript definitions are updated/provided or not needed
  • Tests are updated/provided or not needed
  • Changesets are provided or not needed

@changeset-bot
Copy link

changeset-bot bot commented Sep 20, 2023

🦋 Changeset detected

Latest commit: c12346e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Sep 20, 2023

Deploy Preview for lighthearted-pastelito-e86ad1 ready!

Name Link
🔨 Latest commit c12346e
🔍 Latest deploy log https://app.netlify.com/sites/lighthearted-pastelito-e86ad1/deploys/650ae0f78c02000008feb551
😎 Deploy Preview https://deploy-preview-4975--lighthearted-pastelito-e86ad1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 20, 2023

Deploy Preview for aquamarine-panda-e208bf ready!

Name Link
🔨 Latest commit c12346e
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-panda-e208bf/deploys/650ae0f7678471000763f36c
😎 Deploy Preview https://deploy-preview-4975--aquamarine-panda-e208bf.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 20, 2023

Deploy Preview for zippy-semolina-4ad81e ready!

Name Link
🔨 Latest commit c12346e
🔍 Latest deploy log https://app.netlify.com/sites/zippy-semolina-4ad81e/deploys/650ae0f7614c630008de7855
😎 Deploy Preview https://deploy-preview-4975--zippy-semolina-4ad81e.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 20, 2023

Deploy Preview for refine-crm ready!

Name Link
🔨 Latest commit c12346e
🔍 Latest deploy log https://app.netlify.com/sites/refine-crm/deploys/650ae0f726d6160008148f69
😎 Deploy Preview https://deploy-preview-4975--refine-crm.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 20, 2023

Deploy Preview for imaginative-sundae-1fd394 ready!

Name Link
🔨 Latest commit c12346e
🔍 Latest deploy log https://app.netlify.com/sites/imaginative-sundae-1fd394/deploys/650ae0f7130ce800086d905e
😎 Deploy Preview https://deploy-preview-4975--imaginative-sundae-1fd394.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 20, 2023

Deploy Preview for stupendous-taffy-33f80c ready!

Name Link
🔨 Latest commit c12346e
🔍 Latest deploy log https://app.netlify.com/sites/stupendous-taffy-33f80c/deploys/650ae0f7e88c9c0008361d07
😎 Deploy Preview https://deploy-preview-4975--stupendous-taffy-33f80c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 20, 2023

Deploy Preview for refine-doc-live-previews ready!

Name Link
🔨 Latest commit c12346e
🔍 Latest deploy log https://app.netlify.com/sites/refine-doc-live-previews/deploys/650ae0f7e88c9c0008361d09
😎 Deploy Preview https://deploy-preview-4975--refine-doc-live-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress
Copy link

cypress bot commented Sep 20, 2023

Passing run #10280 ↗︎

0 103 2 0 Flakiness 0

Details:

Merge c12346e into 648699f...
Project: refine Commit: 8e4dc839c8 ℹ️
Status: Passed Duration: 30:29 💡
Started: Sep 20, 2023 12:14 PM Ended: Sep 20, 2023 12:44 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@aliemir aliemir added this pull request to the merge queue Sep 20, 2023
Merged via the queue into next with commit ff66a86 Sep 20, 2023
61 checks passed
@aliemir aliemir deleted the chore/update-tabler-icons-version branch September 20, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants