Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: biome linter issues #5695

Merged
merged 61 commits into from Feb 28, 2024
Merged

Conversation

BatuhanW
Copy link
Member

@BatuhanW BatuhanW commented Feb 27, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

What is the current behavior?

Currently, all of our linter rules are disabled.

What is the new behavior?

Disabled Rules

These rules are disabled intentionally.

  • noForEach
  • noStaticOnlyClass
  • noUselessFragments
  • useSingleVarDeclarator

Enabled Rules

The following rules are fixed and enabled.

a11y

  • noBlankTarget

complexity

  • useOptionalChain
  • noUselessSwitchCase
  • noUselessConstructor
  • noExtraBooleanCast
  • noUselessCatch
  • useArrowFunction
  • noUselessRename

correctness

  • noEmptyPattern
  • noUnsafeOptionalChaining
  • noSwitchDeclarations
  • noUnreachable
  • noConstantCondition

style

  • useTemplate
  • noUnusedTemplateLiteral
  • noUselessElse
  • useSelfClosingElements
  • useConst
  • noCommaOperator

suspicious

  • noRedundantUseStrict
  • noAsyncPromiseExecutor
  • noAssignInExpressions
  • noPrototypeBuiltins
  • noDoubleEquals
  • noGlobalIsNan
  • noRedeclare
  • noDuplicateJsxProps
  • useDefaultSwitchClauseLast
  • noSelfCompare
  • noFallthroughSwitchClause
  • noEmptyInterface
  • noDuplicateObjectKeys
  • useValidTypeof

Remaining Rules

Remaining rules should be fixed separately. Currently they are set to warn.

Notes for reviewers

@refine-bot refine-bot temporarily deployed to deploy-preview-mui-5695 February 28, 2024 11:18 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-website-5695 February 28, 2024 11:34 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-mui-5695 February 28, 2024 12:04 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-antd-5695 February 28, 2024 12:04 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-website-5695 February 28, 2024 12:18 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-antd-5695 February 28, 2024 12:29 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-mui-5695 February 28, 2024 12:30 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-mui-5695 February 28, 2024 12:40 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-antd-5695 February 28, 2024 12:40 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-website-5695 February 28, 2024 12:55 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-mui-5695 February 28, 2024 13:14 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-antd-5695 February 28, 2024 13:15 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants