Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(supabase): change default value of meta.select to "*" #5841

Merged
merged 2 commits into from Apr 25, 2024

Conversation

issa012
Copy link
Contributor

@issa012 issa012 commented Apr 11, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

What is the current behavior?

If meta.select is not specified, update, create, updateMany, createMany methods will not return data.

What is the new behavior?

default value of meta.select is now "*", which selects all data to be returned
fixes #5679

Notes for reviewers

@issa012 issa012 requested a review from a team as a code owner April 11, 2024 08:58
Copy link

changeset-bot bot commented Apr 11, 2024

🦋 Changeset detected

Latest commit: 9675681

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@BatuhanW BatuhanW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @issa012 thanks for catching up on this one! Added a comment about mocks. Other than that, LGTM.

packages/supabase/test/create/index.mock.ts Outdated Show resolved Hide resolved
Copy link

nx-cloud bot commented Apr 24, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9675681. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
lerna run attw --scope @refinedev/*
✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for refine-video-club failed.

Name Link
🔨 Latest commit 9675681
🔍 Latest deploy log https://app.netlify.com/sites/refine-video-club/deploys/662a1f50f754410008fa033b

Copy link
Member

@aliemir aliemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sent a commit to update the tests with respect to the changes in this PR and our supabase database. Thank you for the contribution @issa012!

@aliemir aliemir changed the base branch from master to releases/may April 25, 2024 09:56
@aliemir aliemir changed the title fix: change default value of meta.select to "*" fix(supabase): change default value of meta.select to "*" Apr 25, 2024
@aliemir aliemir merged commit 7b13515 into refinedev:releases/may Apr 25, 2024
16 of 21 checks passed
@aliemir aliemir mentioned this pull request Apr 25, 2024
@aliemir aliemir added this to the May Release milestone Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Using Supabase data provider, the onMutationSuccess callback from useForm doesn't return data
3 participants