Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: qs imports and usage in ESM builds #5850

Merged
merged 2 commits into from Apr 24, 2024
Merged

Conversation

aliemir
Copy link
Member

@aliemir aliemir commented Apr 15, 2024

Updated qs imports and usage to prevent issues with ESM builds and to ensure correctly importing the module.

Resolves #5846
Resolves #5831

@aliemir aliemir requested a review from a team as a code owner April 15, 2024 07:14
Copy link

changeset-bot bot commented Apr 15, 2024

🦋 Changeset detected

Latest commit: 721f693

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

nx-cloud bot commented Apr 15, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 721f693. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 74 targets

Sent with 💌 from NxCloud.

Copy link

cypress bot commented Apr 15, 2024

Passing run #10942 ↗︎

0 378 33 0 Flakiness 0

Details:

Merge 721f693 into b4ed3be...
Project: refine Commit: 49bb9c0de5 ℹ️
Status: Passed Duration: 32:08 💡
Started: Apr 15, 2024 7:22 AM Ended: Apr 15, 2024 7:54 AM

Review all test suite changes for PR #5850 ↗︎

@aliemir aliemir added this to the May Release milestone Apr 16, 2024
@aliemir aliemir changed the base branch from master to releases/may April 24, 2024 10:38
@aliemir aliemir merged commit c2ef59b into releases/may Apr 24, 2024
94 checks passed
@aliemir aliemir deleted the fix/qs-imports-and-usage branch April 24, 2024 11:00
@aliemir aliemir mentioned this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] finefoods-client Sample is broken [BUG] ESM/CJS error with @refinedev/devtools
2 participants