Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): prevent early access to signal from query context #5851

Merged
merged 4 commits into from Apr 24, 2024

Conversation

aliemir
Copy link
Member

@aliemir aliemir commented Apr 15, 2024

In query hooks, signal was accessed directly by destructuring which was causing issues in development mode with duplicated requests. This change accesses queryContext instead of destructured signal properly to prevent @tanstack/react-query from setting abortSignalConsumed flag unexpectedly.

Resolves #5843

@aliemir aliemir requested a review from a team as a code owner April 15, 2024 12:30
Copy link

changeset-bot bot commented Apr 15, 2024

🦋 Changeset detected

Latest commit: a68c5ba

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@refine-bot refine-bot temporarily deployed to deploy-preview-mui-5851 April 15, 2024 12:33 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-antd-5851 April 15, 2024 12:35 Inactive
Copy link

cypress bot commented Apr 15, 2024

Passing run #10951 ↗︎

0 30 4 0 Flakiness 0

Details:

Merge a68c5ba into 4313d24...
Project: refine Commit: d94a343af9 ℹ️
Status: Passed Duration: 12:49 💡
Started: Apr 16, 2024 10:36 PM Ended: Apr 16, 2024 10:49 PM

Review all test suite changes for PR #5851 ↗︎

@aliemir
Copy link
Member Author

aliemir commented Apr 15, 2024

Tests will be updated accordingly. They're failing due to the previous patch done in e2e tests to workaround the issue resolved in this PR 😅

@aliemir aliemir added this to the May Release milestone Apr 16, 2024
@aliemir aliemir changed the base branch from master to releases/may April 24, 2024 10:38
@aliemir aliemir merged commit 8d2dd43 into releases/may Apr 24, 2024
94 checks passed
@aliemir aliemir deleted the refactor/handle-query-signals-properly branch April 24, 2024 11:07
@aliemir aliemir mentioned this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] useSelect hook ignores staleTime
2 participants