Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(antd): search form in useTable should work with syncWithLocation #5981

Merged

Conversation

aliemir
Copy link
Member

@aliemir aliemir commented May 23, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

Changes

Even though the form is managed by useTable hook from @refinedev/antd. It wasn't respecting the syncWithLocation prop to set values accordingly at initial render when registered fields are matching with the query params. Now it will look for matching fields and set values accordingly from synced filters.

RK-630

@aliemir aliemir requested review from a team as code owners May 23, 2024 12:21
Copy link

changeset-bot bot commented May 23, 2024

🦋 Changeset detected

Latest commit: a42d4f8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@refinedev/antd Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@aliemir aliemir changed the base branch from releases/june to master May 23, 2024 12:23
@aliemir aliemir changed the base branch from master to releases/june May 23, 2024 12:23
@refine-bot refine-bot temporarily deployed to deploy-preview-antd-5981 May 23, 2024 12:28 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-mui-5981 May 23, 2024 12:28 Inactive
Copy link

cypress bot commented May 23, 2024

Passing run #11120 ↗︎

0 169 26 0 Flakiness 0

Details:

Merge a42d4f8 into e2ad7a3...
Project: refine Commit: 866278a364 ℹ️
Status: Passed Duration: 16:45 💡
Started: May 23, 2024 1:26 PM Ended: May 23, 2024 1:42 PM

Review all test suite changes for PR #5981 ↗︎

Copy link

netlify bot commented May 23, 2024

Deploy Preview for refine-crm ready!

Name Link
🔨 Latest commit a42d4f8
🔍 Latest deploy log https://app.netlify.com/sites/refine-crm/deploys/664f41e98619ce000858e3fa
😎 Deploy Preview https://deploy-preview-5981--refine-crm.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aliemir aliemir merged commit 90a5a91 into releases/june May 24, 2024
49 checks passed
@aliemir aliemir deleted the feat/antd-persist-search-fields-on-sync-with-location branch May 24, 2024 07:32
@aliemir aliemir mentioned this pull request May 24, 2024
@BatuhanW BatuhanW added this to the June Release milestone May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants