Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devtools): failing auth status checks #6059

Merged
merged 9 commits into from
Jun 20, 2024
Merged

Conversation

aliemir
Copy link
Member

@aliemir aliemir commented Jun 20, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

##Changes

Fixes #6047

Devtools was failing to determine the auth status and always end up redirecting to the login page regardless of the actual auth status. This was due to the missing check on the auth request that was causing all valid responses treated as unauthenticated.

@aliemir aliemir requested a review from a team as a code owner June 20, 2024 11:51
Copy link

changeset-bot bot commented Jun 20, 2024

🦋 Changeset detected

Latest commit: 4908805

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@refinedev/devtools-server Patch
@refinedev/devtools-ui Patch
@refinedev/cli Patch
@refinedev/devtools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

cypress bot commented Jun 20, 2024

Passing run #11208 ↗︎

0 72 31 0 Flakiness 0

Details:

Merge fdcd80d into af04251...
Project: refine Commit: db2b5a35ab ℹ️
Status: Passed Duration: 18:31 💡
Started: Jun 20, 2024 12:50 PM Ended: Jun 20, 2024 1:09 PM

Review all test suite changes for PR #6059 ↗︎

@BatuhanW BatuhanW added this to the July Release milestone Jun 20, 2024
@aliemir aliemir merged commit ad42665 into master Jun 20, 2024
86 of 87 checks passed
@aliemir aliemir deleted the fix/devtools-auth-checks branch June 20, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Invalid session token on login in Safari DevTools
2 participants